refactor: add legacy traits on tests

Vonage · Jan 30, 2024 · 7a56337 · 7a56337
1 parent a37a78f
commit 7a56337
Show file tree

Hide file tree

Showing 25 changed files with 4,226 additions and 4,219 deletions.
diff --git a/Vonage.Test/AccountTest.cs b/Vonage.Test/AccountTest.cs
@@ -7,6 +7,7 @@
 
 namespace Vonage.Test
 {
+    [Trait("Category", "Legacy")]
     public class AccountTest : TestBase
     {
         [Theory]

diff --git a/Vonage.Test/ApplicationTests.cs b/Vonage.Test/ApplicationTests.cs
@@ -10,6 +10,7 @@
 
 namespace Vonage.Test
 {
+    [Trait("Category", "Legacy")]
     public class ApplicationTests : TestBase
     {
         private const string PublicKey = "some public key";

diff --git a/Vonage.Test/ConversionTest.cs b/Vonage.Test/ConversionTest.cs
@@ -2,116 +2,116 @@
 using Vonage.Request;
 using Xunit;
 
-namespace Vonage.Test
+namespace Vonage.Test;
+
+[Trait("Category", "Legacy")]
+public class ConversionTest : TestBase
 {
-    public class ConversionTest : TestBase
+    [Theory]
+    [InlineData(false)]
+    [InlineData(true)]
+    public void SmsConversion(bool passCreds)
     {
-        [Theory]
-        [InlineData(false)]
-        [InlineData(true)]
-        public void SmsConversion(bool passCreds)
+        var expectedUri = $"{this.ApiUrl}/conversions/sms";
+        var expectedContent =
+            "message-id=00A0B0C0&delivered=true&timestamp=2020-01-01+12%3A00%3A00&api_key=testkey&api_secret=testSecret&";
+        var expectedResponse = "";
+        this.Setup(expectedUri, expectedResponse, expectedContent);
+        var request = new ConversionRequest
+            {Delivered = true, MessageId = "00A0B0C0", TimeStamp = "2020-01-01 12:00:00"};
+        var credentials = Credentials.FromApiKeyAndSecret(this.ApiKey, this.ApiSecret);
+        var client = this.BuildVonageClient(credentials);
+        bool response;
+        if (passCreds)
         {
-            var expectedUri = $"{this.ApiUrl}/conversions/sms";
-            var expectedContent =
-                "message-id=00A0B0C0&delivered=true&timestamp=2020-01-01+12%3A00%3A00&api_key=testkey&api_secret=testSecret&";
-            var expectedResponse = "";
-            this.Setup(expectedUri, expectedResponse, expectedContent);
-            var request = new ConversionRequest
-                {Delivered = true, MessageId = "00A0B0C0", TimeStamp = "2020-01-01 12:00:00"};
-            var credentials = Credentials.FromApiKeyAndSecret(this.ApiKey, this.ApiSecret);
-            var client = this.BuildVonageClient(credentials);
-            bool response;
-            if (passCreds)
-            {
-                response = client.ConversionClient.SmsConversion(request, credentials);
-            }
-            else
-            {
-                response = client.ConversionClient.SmsConversion(request);
-            }
-
-            Assert.True(response);
+            response = client.ConversionClient.SmsConversion(request, credentials);
         }
-
-        [Theory]
-        [InlineData(false)]
-        [InlineData(true)]
-        public async void SmsConversionAsync(bool passCreds)
+        else
         {
-            var expectedUri = $"{this.ApiUrl}/conversions/sms";
-            var expectedContent =
-                "message-id=00A0B0C0&delivered=true&timestamp=2020-01-01+12%3A00%3A00&api_key=testkey&api_secret=testSecret&";
-            var expectedResponse = "";
-            this.Setup(expectedUri, expectedResponse, expectedContent);
-            var request = new ConversionRequest
-                {Delivered = true, MessageId = "00A0B0C0", TimeStamp = "2020-01-01 12:00:00"};
-            var creds = Credentials.FromApiKeyAndSecret(this.ApiKey, this.ApiSecret);
-            var client = this.BuildVonageClient(creds);
-            bool response;
-            if (passCreds)
-            {
-                response = await client.ConversionClient.SmsConversionAsync(request, creds);
-            }
-            else
-            {
-                response = await client.ConversionClient.SmsConversionAsync(request);
-            }
-
-            Assert.True(response);
+            response = client.ConversionClient.SmsConversion(request);
         }
 
-        [Theory]
-        [InlineData(false)]
-        [InlineData(true)]
-        public void VoiceConversion(bool passCreds)
-        {
-            var expectedUri = $"{this.ApiUrl}/conversions/voice";
-            var expectedContent =
-                "message-id=00A0B0C0&delivered=true&timestamp=2020-01-01+12%3A00%3A00&api_key=testkey&api_secret=testSecret&";
-            var expectedResponse = "";
-            this.Setup(expectedUri, expectedResponse, expectedContent);
-            var request = new ConversionRequest
-                {Delivered = true, MessageId = "00A0B0C0", TimeStamp = "2020-01-01 12:00:00"};
-            var creds = Credentials.FromApiKeyAndSecret(this.ApiKey, this.ApiSecret);
-            var client = this.BuildVonageClient(creds);
-            bool response;
-            if (passCreds)
-            {
-                response = client.ConversionClient.VoiceConversion(request, creds);
-            }
-            else
-            {
-                response = client.ConversionClient.VoiceConversion(request);
-            }
+        Assert.True(response);
+    }
 
-            Assert.True(response);
+    [Theory]
+    [InlineData(false)]
+    [InlineData(true)]
+    public async void SmsConversionAsync(bool passCreds)
+    {
+        var expectedUri = $"{this.ApiUrl}/conversions/sms";
+        var expectedContent =
+            "message-id=00A0B0C0&delivered=true&timestamp=2020-01-01+12%3A00%3A00&api_key=testkey&api_secret=testSecret&";
+        var expectedResponse = "";
+        this.Setup(expectedUri, expectedResponse, expectedContent);
+        var request = new ConversionRequest
+            {Delivered = true, MessageId = "00A0B0C0", TimeStamp = "2020-01-01 12:00:00"};
+        var creds = Credentials.FromApiKeyAndSecret(this.ApiKey, this.ApiSecret);
+        var client = this.BuildVonageClient(creds);
+        bool response;
+        if (passCreds)
+        {
+            response = await client.ConversionClient.SmsConversionAsync(request, creds);
+        }
+        else
+        {
+            response = await client.ConversionClient.SmsConversionAsync(request);
         }
 
-        [Theory]
-        [InlineData(false)]
-        [InlineData(true)]
-        public async void VoiceConversionAsync(bool passCreds)
+        Assert.True(response);
+    }
+
+    [Theory]
+    [InlineData(false)]
+    [InlineData(true)]
+    public void VoiceConversion(bool passCreds)
+    {
+        var expectedUri = $"{this.ApiUrl}/conversions/voice";
+        var expectedContent =
+            "message-id=00A0B0C0&delivered=true&timestamp=2020-01-01+12%3A00%3A00&api_key=testkey&api_secret=testSecret&";
+        var expectedResponse = "";
+        this.Setup(expectedUri, expectedResponse, expectedContent);
+        var request = new ConversionRequest
+            {Delivered = true, MessageId = "00A0B0C0", TimeStamp = "2020-01-01 12:00:00"};
+        var creds = Credentials.FromApiKeyAndSecret(this.ApiKey, this.ApiSecret);
+        var client = this.BuildVonageClient(creds);
+        bool response;
+        if (passCreds)
+        {
+            response = client.ConversionClient.VoiceConversion(request, creds);
+        }
+        else
         {
-            var expectedUri = $"{this.ApiUrl}/conversions/voice";
-            var expectedContent =
-                "message-id=00A0B0C0&delivered=true&timestamp=2020-01-01+12%3A00%3A00&api_key=testkey&api_secret=testSecret&";
-            var expectedResponse = "";
-            this.Setup(expectedUri, expectedResponse, expectedContent);
-            var request = new ConversionRequest
-                {Delivered = true, MessageId = "00A0B0C0", TimeStamp = "2020-01-01 12:00:00"};
-            var creds = Credentials.FromApiKeyAndSecret(this.ApiKey, this.ApiSecret);
-            var client = this.BuildVonageClient(creds);
-            bool response;
-            if (passCreds)
-            {
-                response = await client.ConversionClient.VoiceConversionAsync(request, creds);
-            }
-            else
-            {
-                response = await client.ConversionClient.VoiceConversionAsync(request);
-            }
+            response = client.ConversionClient.VoiceConversion(request);
+        }
+
+        Assert.True(response);
+    }
 
-            Assert.True(response);
+    [Theory]
+    [InlineData(false)]
+    [InlineData(true)]
+    public async void VoiceConversionAsync(bool passCreds)
+    {
+        var expectedUri = $"{this.ApiUrl}/conversions/voice";
+        var expectedContent =
+            "message-id=00A0B0C0&delivered=true&timestamp=2020-01-01+12%3A00%3A00&api_key=testkey&api_secret=testSecret&";
+        var expectedResponse = "";
+        this.Setup(expectedUri, expectedResponse, expectedContent);
+        var request = new ConversionRequest
+            {Delivered = true, MessageId = "00A0B0C0", TimeStamp = "2020-01-01 12:00:00"};
+        var creds = Credentials.FromApiKeyAndSecret(this.ApiKey, this.ApiSecret);
+        var client = this.BuildVonageClient(creds);
+        bool response;
+        if (passCreds)
+        {
+            response = await client.ConversionClient.VoiceConversionAsync(request, creds);
         }
+        else
+        {
+            response = await client.ConversionClient.VoiceConversionAsync(request);
+        }
+
+        Assert.True(response);
     }
 }
diff --git a/Vonage.Test/EndpointTest.cs b/Vonage.Test/EndpointTest.cs
@@ -6,6 +6,7 @@
 
 namespace Vonage.Test
 {
+    [Trait("Category", "Legacy")]
     public class EndpointTest
     {
         [Fact]

diff --git a/Vonage.Test/Meetings/DeleteRecording/E2ETest.cs b/Vonage.Test/Meetings/DeleteRecording/E2ETest.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Net;
 using System.Threading.Tasks;
+using Vonage.Meetings.DeleteRecording;
 using Vonage.Test.Common.Extensions;
 using WireMock.ResponseBuilders;
 using Xunit;
@@ -23,7 +24,7 @@ public async Task DeleteRecording()
                 .UsingDelete())
             .RespondWith(Response.Create().WithStatusCode(HttpStatusCode.OK));
         await this.Helper.VonageClient.MeetingsClient.DeleteRecordingAsync(
-                Vonage.Meetings.DeleteRecording.Request.Parse(new Guid("48a355bf-924d-4d4d-8e98-78575cf212dd")))
+                DeleteRecordingRequest.Parse(new Guid("48a355bf-924d-4d4d-8e98-78575cf212dd")))
             .Should()
             .BeSuccessAsync();
     }

diff --git a/Vonage.Test/Meetings/DeleteRecording/RequestTest.cs b/Vonage.Test/Meetings/DeleteRecording/RequestTest.cs
@@ -1,6 +1,7 @@
 using System;
 using AutoFixture;
 using FluentAssertions;
+using Vonage.Meetings.DeleteRecording;
 using Vonage.Test.Common.Extensions;
 using Xunit;
 
@@ -13,21 +14,21 @@ public class RequestTest
 
     [Fact]
     public void GetEndpointPath_ShouldReturnApiEndpoint() =>
-        Vonage.Meetings.DeleteRecording.Request.Parse(this.recordingId)
+        DeleteRecordingRequest.Parse(this.recordingId)
             .Map(request => request.GetEndpointPath())
             .Should()
             .BeSuccess(
                 $"/v1/meetings/recordings/{this.recordingId}");
 
     [Fact]
     public void Parse_ShouldReturnFailure_GivenRecordingIdIsNullOrWhitespace() =>
-        Vonage.Meetings.DeleteRecording.Request.Parse(Guid.Empty)
+        DeleteRecordingRequest.Parse(Guid.Empty)
             .Should()
             .BeParsingFailure("RecordingId cannot be empty.");
 
     [Fact]
     public void Parse_ShouldReturnSuccess_GivenValuesAreProvided() =>
-        Vonage.Meetings.DeleteRecording.Request.Parse(this.recordingId)
+        DeleteRecordingRequest.Parse(this.recordingId)
             .Should()
             .BeSuccess(request => request.RecordingId.Should().Be(this.recordingId));
 }