refactor: remove unnecessary parameters in E2ETests

Vonage · Jun 20, 2024 · 8b39bc1 · 8b39bc1
1 parent c468a60
commit 8b39bc1
Show file tree

Hide file tree

Showing 12 changed files with 21 additions and 21 deletions.
diff --git a/Vonage.Test/ConfigurationTest.cs b/Vonage.Test/ConfigurationTest.cs
@@ -259,7 +259,7 @@ public async Task ShouldRenewConnection_GivenIdleTimeoutHasExpired()
     private async Task<int> RefreshConnectionPool(Dictionary<string, string> settings, int timerBuffer, int loops)
     {
         using var spy = new EventSpy();
-        var helper = TestingContext.WithBasicCredentials("Url.Rest", settings);
+        var helper = TestingContext.WithBasicCredentials(settings);
         helper.Server.Given(WireMock.RequestBuilders.Request.Create().UsingGet())
             .RespondWith(Response.Create().WithStatusCode(HttpStatusCode.OK));
         var timer = new PeriodicTimer(TimeSpan.FromSeconds(timerBuffer));

diff --git a/Vonage.Test/Conversations/E2EBase.cs b/Vonage.Test/Conversations/E2EBase.cs
@@ -12,5 +12,5 @@ public class E2EBase
     protected E2EBase(string serializationNamespace) : this() => this.Serialization =
         new SerializationTestHelper(serializationNamespace, JsonSerializerBuilder.BuildWithSnakeCase());
 
-    protected E2EBase() => this.Helper = TestingContext.WithBearerCredentials("Url.Api");
+    protected E2EBase() => this.Helper = TestingContext.WithBearerCredentials();
 }
diff --git a/Vonage.Test/Meetings/E2EBase.cs b/Vonage.Test/Meetings/E2EBase.cs
@@ -11,7 +11,7 @@ public abstract class E2EBase
 
     protected E2EBase(string serializationNamespace)
     {
-        this.Helper = TestingContext.WithBearerCredentials("Url.Api.EMEA");
+        this.Helper = TestingContext.WithBearerCredentials();
         this.Serialization =
             new SerializationTestHelper(serializationNamespace, JsonSerializerBuilder.BuildWithSnakeCase());
     }

diff --git a/Vonage.Test/NumberInsightsV2/FraudCheck/E2ETest.cs b/Vonage.Test/NumberInsightsV2/FraudCheck/E2ETest.cs
@@ -21,27 +21,27 @@ public class E2ETest
 
     [Fact]
     public async Task PerformFraudCheck_WithFraudScore_UsingBasicCredentials() =>
-        await this.PerformFraudCheckWithFraudScore(TestingContext.WithBasicCredentials(ApiUrl));
+        await this.PerformFraudCheckWithFraudScore(TestingContext.WithBasicCredentials());
 
     [Fact]
     public async Task PerformFraudCheck_WithFraudScore_UsingBearerCredentials() =>
-        await this.PerformFraudCheckWithFraudScore(TestingContext.WithBearerCredentials(ApiUrl));
+        await this.PerformFraudCheckWithFraudScore(TestingContext.WithBearerCredentials());
 
     [Fact]
     public async Task PerformFraudCheck_WithFraudScoreAndSimSwap_UsingBasicCredentials() =>
-        await this.PerformFraudCheckWithFraudScoreAndSimSwap(TestingContext.WithBasicCredentials(ApiUrl));
+        await this.PerformFraudCheckWithFraudScoreAndSimSwap(TestingContext.WithBasicCredentials());
 
     [Fact]
     public async Task PerformFraudCheck_WithFraudScoreAndSimSwap_UsingBearerCredentials() =>
-        await this.PerformFraudCheckWithFraudScoreAndSimSwap(TestingContext.WithBearerCredentials(ApiUrl));
+        await this.PerformFraudCheckWithFraudScoreAndSimSwap(TestingContext.WithBearerCredentials());
 
     [Fact]
     public async Task PerformFraudCheck_WithSimSwap_UsingBasicCredentials() =>
-        await this.PerformFraudCheckWithSimSwap(TestingContext.WithBasicCredentials(ApiUrl));
+        await this.PerformFraudCheckWithSimSwap(TestingContext.WithBasicCredentials());
 
     [Fact]
     public async Task PerformFraudCheck_WithSimSwap_UsingBearerCredentials() =>
-        await this.PerformFraudCheckWithSimSwap(TestingContext.WithBearerCredentials(ApiUrl));
+        await this.PerformFraudCheckWithSimSwap(TestingContext.WithBearerCredentials());
 
     private async Task PerformFraudCheck(TestingContext helper, string body, Result<FraudCheckRequest> request)
     {

diff --git a/Vonage.Test/NumberVerification/E2EBase.cs b/Vonage.Test/NumberVerification/E2EBase.cs
@@ -12,5 +12,5 @@ public class E2EBase
     protected E2EBase(string serializationNamespace) : this() => this.Serialization =
         new SerializationTestHelper(serializationNamespace, JsonSerializerBuilder.BuildWithSnakeCase());
 
-    protected E2EBase() => this.Helper = TestingContext.WithBearerCredentials("Url.Api.EMEA");
+    protected E2EBase() => this.Helper = TestingContext.WithBearerCredentials();
 }
diff --git a/Vonage.Test/ProactiveConnect/E2EBase.cs b/Vonage.Test/ProactiveConnect/E2EBase.cs
@@ -11,7 +11,7 @@ public abstract class E2EBase
 
     protected E2EBase(string serializationNamespace)
     {
-        this.Helper = TestingContext.WithBearerCredentials("Url.Api.EMEA");
+        this.Helper = TestingContext.WithBearerCredentials();
         this.Serialization =
             new SerializationTestHelper(serializationNamespace, JsonSerializerBuilder.BuildWithSnakeCase());
     }

diff --git a/Vonage.Test/SimSwap/E2EBase.cs b/Vonage.Test/SimSwap/E2EBase.cs
@@ -8,9 +8,9 @@ public class E2EBase
 {
     internal readonly TestingContext Helper;
     internal readonly SerializationTestHelper Serialization;
-    
+
     protected E2EBase(string serializationNamespace) : this() => this.Serialization =
         new SerializationTestHelper(serializationNamespace, JsonSerializerBuilder.BuildWithSnakeCase());
-    
-    protected E2EBase() => this.Helper = TestingContext.WithBearerCredentials("Url.Api.EMEA");
+
+    protected E2EBase() => this.Helper = TestingContext.WithBearerCredentials();
 }
diff --git a/Vonage.Test/SubAccounts/E2EBase.cs b/Vonage.Test/SubAccounts/E2EBase.cs
@@ -11,7 +11,7 @@ public abstract class E2EBase
 
     protected E2EBase(string serializationNamespace)
     {
-        this.Helper = TestingContext.WithBasicCredentials("Url.Api");
+        this.Helper = TestingContext.WithBasicCredentials();
         this.Serialization =
             new SerializationTestHelper(serializationNamespace, JsonSerializerBuilder.BuildWithSnakeCase());
     }

diff --git a/Vonage.Test/TestHelpers/TestingContext.cs b/Vonage.Test/TestHelpers/TestingContext.cs
@@ -37,14 +37,14 @@ public void Dispose()
         GC.SuppressFinalize(this);
     }
 
-    public static TestingContext WithBasicCredentials(string appSettingsKey) =>
+    public static TestingContext WithBasicCredentials() =>
         new TestingContext(CreateBasicCredentials(), "Basic NzkwZmM1ZTU6QWEzNDU2Nzg5",
             new Dictionary<string, string>());
 
-    public static TestingContext WithBearerCredentials(string appSettingsKey) =>
+    public static TestingContext WithBearerCredentials() =>
         new TestingContext(CreateBearerCredentials(), "Bearer *", new Dictionary<string, string>());
 
-    public static TestingContext WithBasicCredentials(string appSettingsKey, Dictionary<string, string> settings) =>
+    public static TestingContext WithBasicCredentials(Dictionary<string, string> settings) =>
         new TestingContext(CreateBasicCredentials(), "Basic NzkwZmM1ZTU6QWEzNDU2Nzg5", settings);
 
     private static Credentials CreateBasicCredentials() => Credentials.FromApiKeyAndSecret("790fc5e5", "Aa3456789");

diff --git a/Vonage.Test/Users/E2EBase.cs b/Vonage.Test/Users/E2EBase.cs
@@ -17,7 +17,7 @@ public class E2EBase
     protected E2EBase(string serializationNamespace) : this() => this.Serialization =
         new SerializationTestHelper(serializationNamespace, JsonSerializerBuilder.BuildWithSnakeCase());
 
-    protected E2EBase() => this.Helper = TestingContext.WithBearerCredentials("Url.Api");
+    protected E2EBase() => this.Helper = TestingContext.WithBearerCredentials();
 
     internal static void VerifyUser(User success)
     {

diff --git a/Vonage.Test/VerifyV2/E2EBase.cs b/Vonage.Test/VerifyV2/E2EBase.cs
@@ -12,5 +12,5 @@ public class E2EBase
     protected E2EBase(string serializationNamespace) : this() => this.Serialization =
         new SerializationTestHelper(serializationNamespace, JsonSerializerBuilder.BuildWithSnakeCase());
 
-    protected E2EBase() => this.Helper = TestingContext.WithBearerCredentials("Url.Api");
+    protected E2EBase() => this.Helper = TestingContext.WithBearerCredentials();
 }
diff --git a/Vonage.Test/Video/E2EBase.cs b/Vonage.Test/Video/E2EBase.cs
@@ -8,7 +8,7 @@ public abstract class E2EBase
 {
     internal readonly TestingContext Helper;
     internal readonly SerializationTestHelper Serialization;
-    private E2EBase() => this.Helper = TestingContext.WithBearerCredentials("Url.Api.Video");
+    private E2EBase() => this.Helper = TestingContext.WithBearerCredentials();
 
     protected E2EBase(string serializationNamespace) : this() => this.Serialization =
         new SerializationTestHelper(serializationNamespace,