fix: read feature on MaybeJsonConverter (#539)

* Fix MaybeJsonConverter Read method

* Simplify read implementation

Vonage.Common.Test/Serialization/MaybeJsonConverterTest.cs

@@ -0,0 +1,23 @@
+using System.Text.Json;
+using Vonage.Common.Serialization;
+using Vonage.Common.Test.Extensions;
+
+namespace Vonage.Common.Test.Serialization
+{
+    public class MaybeJsonConverterTest
+    {
+        [Fact]
+        public void Read_ShouldDeserializeUri_GivenJsonIsUriString()
+        {
+            var reader =
+                new Utf8JsonReader(
+                    "\"https://api.nexmo.com/v2/verify/c11236f4-00bf-4b89-84ba-88b25df97315/silent-auth/redirect\""u8
+                        .ToArray().AsSpan());
+            reader.Read();
+            new MaybeJsonConverter<Uri>().Read(ref reader, typeof(Uri), new JsonSerializerOptions())
+                .Should()
+                .BeSome(new Uri(
+                    "https://api.nexmo.com/v2/verify/c11236f4-00bf-4b89-84ba-88b25df97315/silent-auth/redirect"));
+        }
+    }
+}

Vonage.Common/Serialization/MaybeJsonConverter.cs

@@ -11,19 +11,16 @@ namespace Vonage.Common.Serialization;
 /// <typeparam name="T">The underlying type.</typeparam>
 public class MaybeJsonConverter<T> : JsonConverter<Maybe<T>>
 {
-    public MaybeJsonConverter() => this.serializer = new JsonSerializer();
-
     /// <inheritdoc />
     public override Maybe<T> Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) =>
-        this.serializer
-            .DeserializeObject<T>(reader.GetString())
+        this.Serializer.DeserializeObject<T>($"\"{reader.GetString()}\"")
             .Match(Maybe<T>.Some, _ => Maybe<T>.None);
 
     /// <inheritdoc />
     public override void Write(Utf8JsonWriter writer, Maybe<T> value, JsonSerializerOptions options) =>
         value
-            .Map(some => this.serializer.SerializeObject(some))
+            .Map(some => this.Serializer.SerializeObject(some))
             .IfSome(some => writer.WriteRawValue(some));
 
-    protected JsonSerializer serializer;
+    protected JsonSerializer Serializer = new();
 }

Vonage/Common/VonageMaybeJsonConverter.cs

@@ -13,7 +13,7 @@ public class VonageMaybeJsonConverter<T> : MaybeJsonConverter<T>
     ///     Constructor.
     /// </summary>
     public VonageMaybeJsonConverter() =>
-        this.serializer = JsonSerializer.BuildWithSnakeCase()
+        this.Serializer = JsonSerializer.BuildWithSnakeCase()
             .WithConverter(new EnumDescriptionJsonConverter<RoomApprovalLevel>())
             .WithConverter(new EnumDescriptionJsonConverter<RecordingStatus>())
             .WithConverter(new EnumDescriptionJsonConverter<RoomType>())