refactor: [breaking] remove sync methods from ApplicationClient

Vonage · Mar 14, 2024 · e8f90f6 · e8f90f6
1 parent 09062db
commit e8f90f6
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 527 deletions.
diff --git a/Vonage.Test/ApplicationTests.cs b/Vonage.Test/ApplicationTests.cs
diff --git a/...ationTests/CreateApplication-request.json → ...Tests/CreateApplicationAsync-request.json b/...ationTests/CreateApplication-request.json → ...Tests/CreateApplicationAsync-request.json
diff --git a/...tionTests/CreateApplication-response.json → ...ests/CreateApplicationAsync-response.json b/...tionTests/CreateApplication-response.json → ...ests/CreateApplicationAsync-response.json
diff --git a/...tionWithMeetingsCapabilities-request.json → ...syncWithMeetingsCapabilities-request.json b/...tionWithMeetingsCapabilities-request.json → ...syncWithMeetingsCapabilities-request.json
diff --git a/...ionWithMeetingsCapabilities-response.json → ...yncWithMeetingsCapabilities-response.json b/...ionWithMeetingsCapabilities-response.json → ...yncWithMeetingsCapabilities-response.json
diff --git a/Vonage.Test/Vonage.Test.csproj b/Vonage.Test/Vonage.Test.csproj
@@ -86,10 +86,10 @@
         <None Update="Data\NccoTests\TestConversationAllTrue-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\ApplicationTests\CreateApplication-response.json">
+        <None Update="Data\ApplicationTests\CreateApplicationAsync-response.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\ApplicationTests\CreateApplication-request.json">
+        <None Update="Data\ApplicationTests\CreateApplicationAsync-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
         <None Update="Data\NumberInsightsTests\TestAdvancedNIRequestSyncRealTimeData-response.json">
@@ -873,10 +873,10 @@
         <None Update="Data\ApplicationTests\GetApplication-response.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\ApplicationTests\CreateApplicationWithMeetingsCapabilities-request.json">
+        <None Update="Data\ApplicationTests\CreateApplicationAsyncWithMeetingsCapabilities-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
-        <None Update="Data\ApplicationTests\CreateApplicationWithMeetingsCapabilities-response.json">
+        <None Update="Data\ApplicationTests\CreateApplicationAsyncWithMeetingsCapabilities-response.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
         <None Update="VerifyV2\StartVerification\Data\ShouldDeserialize200WithCheckUrl-response.json">

diff --git a/Vonage/Applications/ApplicationClient.cs b/Vonage/Applications/ApplicationClient.cs
@@ -1,4 +1,3 @@
-using System;
 using System.Net.Http;
 using System.Threading.Tasks;
 using Vonage.Common;
@@ -26,28 +25,6 @@ internal ApplicationClient(Credentials credentials, Configuration configuration,
 
     public Credentials Credentials { get; set; }
 
-    /// <inheritdoc/>
-    [Obsolete("Favor asynchronous version instead.")]
-    public Application CreateApplicaiton(CreateApplicationRequest request, Credentials creds = null) =>
-        ApiRequest.Build(this.GetCredentials(creds), this.configuration, this.timeProvider)
-            .DoRequestWithJsonContent<Application>(
-                HttpMethod.Post,
-                ApiRequest.GetBaseUri(ApiRequest.UriType.Api, this.configuration, "/v2/applications"),
-                request,
-                AuthType.Basic
-            );
-
-    /// <inheritdoc/>
-    [Obsolete("Favor typo-free method instead.")]
-    public Task<Application> CreateApplicaitonAsync(CreateApplicationRequest request, Credentials creds = null) =>
-        ApiRequest.Build(this.GetCredentials(creds), this.configuration, this.timeProvider)
-            .DoRequestWithJsonContentAsync<Application>(
-                HttpMethod.Post,
-                ApiRequest.GetBaseUri(ApiRequest.UriType.Api, this.configuration, "/v2/applications"),
-                request,
-                AuthType.Basic
-            );
-
     /// <inheritdoc />
     public Task<Application> CreateApplicationAsync(CreateApplicationRequest request, Credentials creds = null) =>
         ApiRequest.Build(this.GetCredentials(creds), this.configuration, this.timeProvider)
@@ -58,19 +35,6 @@ internal ApplicationClient(Credentials credentials, Configuration configuration,
                 AuthType.Basic
             );
 
-    /// <inheritdoc/>
-    [Obsolete("Favor asynchronous version instead.")]
-    public bool DeleteApplication(string id, Credentials creds = null)
-    {
-        ApiRequest.Build(this.GetCredentials(creds), this.configuration, this.timeProvider)
-            .DoDeleteRequestWithUrlContent(
-                ApiRequest.GetBaseUri(ApiRequest.UriType.Api, this.configuration, $"/v2/applications/{id}"),
-                null,
-                AuthType.Basic
-            );
-        return true;
-    }
-
     /// <inheritdoc/>
     public async Task<bool> DeleteApplicationAsync(string id, Credentials creds = null)
     {
@@ -83,15 +47,6 @@ await ApiRequest.Build(this.GetCredentials(creds), this.configuration, this.time
         return true;
     }
 
-    /// <inheritdoc/>
-    [Obsolete("Favor asynchronous version instead.")]
-    public Application GetApplication(string id, Credentials creds = null) =>
-        ApiRequest.Build(this.GetCredentials(creds), this.configuration, this.timeProvider)
-            .DoGetRequestWithQueryParameters<Application>(
-                ApiRequest.GetBaseUri(ApiRequest.UriType.Api, this.configuration, $"/v2/applications/{id}"),
-                AuthType.Basic
-            );
-
     /// <inheritdoc/>
     public Task<Application> GetApplicationAsync(string id, Credentials creds = null) =>
         ApiRequest.Build(this.GetCredentials(creds), this.configuration, this.timeProvider)
@@ -100,16 +55,6 @@ await ApiRequest.Build(this.GetCredentials(creds), this.configuration, this.time
                 AuthType.Basic
             );
 
-    /// <inheritdoc/>
-    [Obsolete("Favor asynchronous version instead.")]
-    public ApplicationPage ListApplications(ListApplicationsRequest request, Credentials creds = null) =>
-        ApiRequest.Build(this.GetCredentials(creds), this.configuration, this.timeProvider)
-            .DoGetRequestWithQueryParameters<ApplicationPage>(
-                ApiRequest.GetBaseUri(ApiRequest.UriType.Api, this.configuration, "/v2/applications"),
-                AuthType.Basic,
-                request
-            );
-
     /// <inheritdoc/>
     public Task<ApplicationPage> ListApplicationsAsync(ListApplicationsRequest request, Credentials creds = null) =>
         ApiRequest.Build(this.GetCredentials(creds), this.configuration, this.timeProvider)
@@ -119,17 +64,6 @@ await ApiRequest.Build(this.GetCredentials(creds), this.configuration, this.time
                 request
             );
 
-    /// <inheritdoc/>
-    [Obsolete("Favor asynchronous version instead.")]
-    public Application UpdateApplication(string id, CreateApplicationRequest request, Credentials creds = null) =>
-        ApiRequest.Build(this.GetCredentials(creds), this.configuration, this.timeProvider)
-            .DoRequestWithJsonContent<Application>(
-                HttpMethod.Put,
-                ApiRequest.GetBaseUri(ApiRequest.UriType.Api, this.configuration, $"/v2/applications/{id}"),
-                request,
-                AuthType.Basic
-            );
-
     /// <inheritdoc/>
     public Task<Application> UpdateApplicationAsync(string id, CreateApplicationRequest request,
         Credentials creds = null) =>

diff --git a/Vonage/Applications/IApplicationClient.cs b/Vonage/Applications/IApplicationClient.cs
@@ -5,22 +5,6 @@ namespace Vonage.Applications;
 
 public interface IApplicationClient
 {
-    /// <summary>
-    /// Application Name
-    /// </summary>
-    /// <param name="request"></param>
-    /// <param name="creds"></param>
-    /// <returns></returns>
-    Application CreateApplicaiton(CreateApplicationRequest request, Credentials creds = null);
-
-    /// <summary>
-    /// Application Name
-    /// </summary>
-    /// <param name="request"></param>
-    /// <param name="creds"></param>
-    /// <returns></returns>
-    Task<Application> CreateApplicaitonAsync(CreateApplicationRequest request, Credentials creds = null);
-
     /// <summary>
     ///     Creates a new application.
     /// </summary>
@@ -29,14 +13,6 @@ public interface IApplicationClient
     /// <returns>The application.</returns>
     Task<Application> CreateApplicationAsync(CreateApplicationRequest request, Credentials creds = null);
 
-    /// <summary>
-    /// Deletes an application: Cannot be undone
-    /// </summary>
-    /// <param name="id">Id of the application to be deleted</param>
-    /// <param name="creds"></param>
-    /// <returns></returns>
-    bool DeleteApplication(string id, Credentials creds = null);
-
     /// <summary>
     /// Deletes an application: Cannot be undone
     /// </summary>
@@ -45,14 +21,6 @@ public interface IApplicationClient
     /// <returns></returns>
     Task<bool> DeleteApplicationAsync(string id, Credentials creds = null);
 
-    /// <summary>
-    /// Retrieves information about an application
-    /// </summary>
-    /// <param name="id">Id of the application to be retrieved</param>
-    /// <param name="creds"></param>
-    /// <returns></returns>
-    Application GetApplication(string id, Credentials creds = null);
-
     /// <summary>
     /// Retrieves information about an application
     /// </summary>
@@ -61,14 +29,6 @@ public interface IApplicationClient
     /// <returns></returns>
     Task<Application> GetApplicationAsync(string id, Credentials creds = null);
 
-    /// <summary>
-    /// List applications
-    /// </summary>
-    /// <param name="request"></param>
-    /// <param name="creds"></param>
-    /// <returns></returns>
-    ApplicationPage ListApplications(ListApplicationsRequest request, Credentials creds = null);
-
     /// <summary>
     /// List applications
     /// </summary>
@@ -77,15 +37,6 @@ public interface IApplicationClient
     /// <returns></returns>
     Task<ApplicationPage> ListApplicationsAsync(ListApplicationsRequest request, Credentials creds = null);
 
-    /// <summary>
-    /// Updates an Application
-    /// </summary>
-    /// <param name="id">Id of the application to be updated</param>
-    /// <param name="request"></param>
-    /// <param name="creds"></param>
-    /// <returns></returns>
-    Application UpdateApplication(string id, CreateApplicationRequest request, Credentials creds = null);
-
     /// <summary>
     /// Updates an Application
     /// </summary>