Skip to content

Commit

Permalink
refactor: [breaking] remove EventUrl and EventMethod from Conversatio…
Browse files Browse the repository at this point in the history
…nAction, with a disclaimer in the Readme
  • Loading branch information
Tr00d committed Apr 15, 2024
1 parent 11bb4ef commit fd02cd5
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 19 deletions.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ first.

#### Upgrading from v6.x.x to v7.0.0

Disclaimer: Due to a forgotten breaking changes,
versions [v7.0.0](https://github.com/Vonage/vonage-dotnet-sdk/releases/tag/v7.0.0)
and [v7.1.0](https://github.com/Vonage/vonage-dotnet-sdk/releases/tag/v7.1.0) have been unlisted to
make [v7.2.0](https://github.com/Vonage/vonage-dotnet-sdk/releases/tag/v7.2.0) the logical upgrade when migrating
towards the new major version.

Please see the dedicated [migration guide](MIGRATION_v7.0.0.md).

#### Upgrading from v5.x.x to v6.0.0
Expand Down
26 changes: 7 additions & 19 deletions Vonage/Voice/Nccos/ConversationAction.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,23 @@ public class ConversationAction : NccoAction
/// </summary>
[JsonProperty("action", Order = 0)]
public override ActionType Action => ActionType.Conversation;

/// <summary>
/// A list of leg UUIDs that this participant can hear.
/// If not provided, the participant can hear everyone.
/// If an empty list is provided, the participant will not hear any other participants
/// </summary>
[JsonProperty("canHear", Order = 7)]
public string[] CanHear { get; set; }

/// <summary>
/// A list of leg UUIDs that this participant can be heard by.
/// If not provided, the participant can be heard by everyone.
/// If an empty list is provided, the participant will not be heard by anyone
/// </summary>
[JsonProperty("canSpeak", Order = 6)]
public string[] CanSpeak { get; set; }

/// <summary>
/// Specifies whether a moderated conversation ends when the moderator hangs up.
/// This is set to false by default, which means that the conversation only ends
Expand All @@ -38,19 +38,7 @@ public class ConversationAction : NccoAction
/// </summary>
[JsonProperty("endOnExit", Order = 4)]
public bool EndOnExit { get; set; }

/// <summary>
/// Method to use on the webhooks for the conversation
/// </summary>
[JsonProperty("eventMethod")]
public string EventMethod { get; set; }

/// <summary>
/// Url to receive webhooks at for the conversation
/// </summary>
[JsonProperty("eventUrl")]
public string[] EventUrl { get; set; }


/// <summary>
/// A URL to the mp3 file to stream to participants until the conversation starts.
/// By default the conversation starts when the first person calls the virtual number
Expand All @@ -59,13 +47,13 @@ public class ConversationAction : NccoAction
/// </summary>
[JsonProperty("musicOnHoldUrl", Order = 2)]
public string[] MusicOnHoldUrl { get; set; }

/// <summary>
/// The name of the Conversation room. Names are namespaced to the application level.
/// </summary>
[JsonProperty("name", Order = 1)]
public string Name { get; set; }

/// <summary>
/// Set to true to record this conversation. For standard conversations,
/// recordings start when one or more attendees connects to the conversation.
Expand All @@ -77,7 +65,7 @@ public class ConversationAction : NccoAction
/// </summary>
[JsonProperty("record", Order = 5)]
public bool Record { get; set; }

/// <summary>
/// The default value of true ensures that the conversation starts when this caller
/// joins conversation name. Set to false for attendees in a moderated conversation.
Expand Down

0 comments on commit fd02cd5

Please sign in to comment.