Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVX-7140] Remove hardcoded keys #373

Merged
merged 7 commits into from
Mar 17, 2023
Merged

[DEVX-7140] Remove hardcoded keys #373

merged 7 commits into from
Mar 17, 2023

Conversation

Tr00d
Copy link
Contributor

@Tr00d Tr00d commented Mar 16, 2023 •
edited

  • Replace RSA Private Keys with environment variables
  • Replace Public/Private keys with fake value

@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Tr00d Tr00d requested a review from pardel March 16, 2023 14:37
@Tr00d Tr00d merged commit 3c54086 into main Mar 17, 2023
@Tr00d Tr00d deleted the devx-7140 branch March 17, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manchuck manchuck manchuck approved these changes

@pardel pardel Awaiting requested review from pardel

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tr00d @manchuck