Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verifyV2 fraud check #409

Merged
merged 3 commits into from
May 15, 2023
Merged

feat: verifyV2 fraud check #409

merged 3 commits into from
May 15, 2023

Conversation

Tr00d
Copy link
Contributor

@Tr00d Tr00d commented May 10, 2023

No description provided.

@Tr00d Tr00d added the feature label May 10, 2023
@@ -36,6 +36,11 @@ namespace Vonage.VerifyV2.StartVerification;
/// </summary>
public int CodeLength { get; internal init; }

/// <summary>
/// Indicates if the request goes though a network block for Fraud Check.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Bool flag to bypass network block, if necessary

Copy link

@SecondeJK SecondeJK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on condition of docs tweak just to make it a little clearer for devs

Tr00d added 2 commits May 15, 2023 14:57
# Conflicts:
#	Vonage.Test.Unit/VerifyV2/StartVerification/SerializationTest.cs
#	Vonage/VerifyV2/StartVerification/StartVerificationRequestBuilder.cs
@sonarcloud
Copy link

sonarcloud bot commented May 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Tr00d Tr00d merged commit 0d9e0d4 into main May 15, 2023
@Tr00d Tr00d deleted the devx-7198 branch May 19, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants