Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: voice advanced machine detection #412

Merged
merged 9 commits into from
May 19, 2023
Merged

feat: voice advanced machine detection #412

merged 9 commits into from
May 19, 2023

Conversation

Tr00d
Copy link
Contributor

@Tr00d Tr00d commented May 12, 2023

No description provided.

@Tr00d Tr00d added feature refactoring Modifications that don't alter any public API or behavior labels May 12, 2023
@Tr00d Tr00d marked this pull request as ready for review May 16, 2023 08:59
SMadani
SMadani requested changes May 16, 2023
View reviewed changes
Copy link

@SMadani SMadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also add advancedMachineDetection to the ConnectAction NCCO.

@Tr00d Tr00d requested a review from SMadani May 17, 2023 11:03
@sonarcloud
Copy link

sonarcloud bot commented May 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Tr00d Tr00d merged commit 95c55be into main May 19, 2023
@Tr00d Tr00d deleted the devx-7291 branch May 19, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMadani SMadani SMadani approved these changes

Assignees
No one assigned
Labels
feature refactoring Modifications that don't alter any public API or behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tr00d @SMadani