refactor: update TestBase #523
Merged
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Sep 19, 2023 in 32s
CodeScene PR Check
✅ Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
Details
🚩 Negative Code Health Impact (highest to lowest):
- Primitive Obsession TestBase.cs
✅ Positive Code Health Impact (highest to lowest):
- Code Duplication TestBase.cs
Annotations
Check warning on line 1 in Vonage.Test.Unit/TestBase.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Primitive Obsession
In this module, 60.0% of all function arguments are primitive types, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Check notice on line 1 in Vonage.Test.Unit/TestBase.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: String Heavy Function Arguments
The ratio of strings in function arguments increases from 55.56% to 60.00%, threshold = 39.0%. The functions in this file have a high ratio of strings as arguments. Avoid adding more.
Check notice on line 1 in Vonage.Test.Unit/TestBase.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Code Duplication
The module no longer contains too many functions with similar structure
Loading