Fix edge case importing RSA key #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @OronDF343, Thanks for looking into this 👏 The problem didn't occur for a year so, as you said, it's probably related to older keys. |
|
@OronDF343, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes edge case Exception importing private key when
Dis shorter in length thanMODULUSby 8 bits or more.If
Dis shorter, it is copied to the end of a new array with the same length asMODULUS. Naive, but this is a rare edge case.Motivation and Context
This fixes issue #357 that I just ran into using an older Vonage application private key.
How Has This Been Tested?
Ran unit tests with old and new keys and published to our production server (which uses multiple private keys).