refactor: Simplify transferCall NCCO

Vonage · Jul 1, 2024 · 1b4e30f · 1b4e30f
1 parent 930267e
commit 1b4e30f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/main/kotlin/com/vonage/client/kt/Voice.kt b/src/main/kotlin/com/vonage/client/kt/Voice.kt
@@ -1,6 +1,7 @@
 package com.vonage.client.kt
 
 import com.vonage.client.voice.*
+import com.vonage.client.voice.ncco.Action
 import com.vonage.client.voice.ncco.Ncco
 import java.net.URI
 import java.time.Instant
@@ -26,7 +27,7 @@ class Voice(private val voiceClient: VoiceClient) {
 
         fun unearmuff() = voiceClient.unearmuffCall(callId)
 
-        fun transfer(ncco: Ncco) = voiceClient.transferCall(callId, ncco)
+        fun transfer(vararg actions: Action) = voiceClient.transferCall(callId, Ncco(actions.asList()))
 
         fun transfer(nccoUrl: String) = voiceClient.transferCall(callId, nccoUrl)
 
@@ -60,4 +61,5 @@ fun CallsFilter.Builder.dateEnd(dateEnd: String): CallsFilter.Builder =
     dateEnd(Date.from(Instant.parse(dateEnd)))
 
 fun Call.Builder.advancedMachineDetection(amd: AdvancedMachineDetection.Builder.() -> Unit): Call.Builder =
-    advancedMachineDetection(AdvancedMachineDetection.builder().apply(amd).build());
+    advancedMachineDetection(AdvancedMachineDetection.builder().apply(amd).build())
+
diff --git a/src/test/kotlin/com/vonage/client/kt/VoiceTest.kt b/src/test/kotlin/com/vonage/client/kt/VoiceTest.kt
@@ -212,7 +212,7 @@ class VoiceTest : AbstractTest() {
     @Test
     fun `transfer call with ncco`() {
         testModifyCall(nccoAction = mapOf("action" to "talk", "text" to text), invocation = {
-            callObj.transfer(Ncco(TalkAction.builder(text).build()))
+            callObj.transfer(TalkAction.builder(text).build())
         })
     }