Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(verify2): check code not returning status #823

Merged
merged 1 commit into from
May 19, 2023
Merged

Conversation

manchuck
Copy link
Contributor

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck marked this pull request as ready for review May 18, 2023 17:33
@codecov-commenter
Copy link

Codecov Report

Merging #823 (ed90266) into 3.x (15bfc32) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              3.x     #823   +/-   ##
=======================================
  Coverage   79.58%   79.58%           
=======================================
  Files          99       99           
  Lines        1259     1259           
  Branches      252      252           
=======================================
  Hits         1002     1002           
  Misses        256      256           
  Partials        1        1           
Impacted Files Coverage Δ
packages/verify2/lib/verify2.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@manchuck manchuck merged commit 3e04e19 into 3.x May 19, 2023
@manchuck manchuck deleted the verify-v2-fix branch May 19, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants