Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releaase(verify2): verify v2 to ga #825

Merged
merged 1 commit into from
May 23, 2023
Merged

releaase(verify2): verify v2 to ga #825

merged 1 commit into from
May 23, 2023

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented May 22, 2023

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck added the don't merge Don't merge this code at this time label May 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023

Codecov Report

Merging #825 (5dea558) into 3.x (c93bc3d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              3.x     #825      +/-   ##
==========================================
+ Coverage   79.66%   79.68%   +0.01%     
==========================================
  Files          99       99              
  Lines        1264     1265       +1     
  Branches      252      252              
==========================================
+ Hits         1007     1008       +1     
  Misses        256      256              
  Partials        1        1              
Impacted Files Coverage Δ
packages/server-sdk/lib/vonage.ts 94.11% <100.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@manchuck manchuck removed the don't merge Don't merge this code at this time label May 23, 2023
@manchuck manchuck marked this pull request as ready for review May 23, 2023 13:19
Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manchuck manchuck merged commit 4097b53 into 3.x May 23, 2023
@manchuck manchuck deleted the verify-v2-ga branch May 23, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants