Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(applications): updating types for application package #827

Merged
merged 1 commit into from
May 25, 2023

Conversation

manchuck
Copy link
Contributor

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023

Codecov Report

Merging #827 (0e4b0e4) into 3.x (69239f3) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              3.x     #827      +/-   ##
==========================================
+ Coverage   79.68%   79.93%   +0.25%     
==========================================
  Files          99       99              
  Lines        1265     1281      +16     
  Branches      252      255       +3     
==========================================
+ Hits         1008     1024      +16     
  Misses        256      256              
  Partials        1        1              
Impacted Files Coverage Δ
packages/applications/lib/applications.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@manchuck manchuck merged commit 2ff4e5a into 3.x May 25, 2023
@manchuck manchuck deleted the fix-applications branch May 25, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants