Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added verifySignature to jwt package #860

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Aug 21, 2023

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck marked this pull request as ready for review August 21, 2023 15:20
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #860 (064aaf3) into 3.x (f974dd6) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              3.x     #860      +/-   ##
==========================================
+ Coverage   84.16%   84.25%   +0.08%     
==========================================
  Files         120      120              
  Lines        1554     1562       +8     
  Branches      300      300              
==========================================
+ Hits         1308     1316       +8     
  Misses        245      245              
  Partials        1        1              
Files Changed Coverage Δ
packages/jwt/lib/index.ts 100.00% <100.00%> (ø)
packages/jwt/lib/jwt.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

packages/jwt/__tests__/jwt.test.ts Outdated Show resolved Hide resolved
@manchuck manchuck merged commit 7c75951 into 3.x Aug 21, 2023
9 checks passed
@manchuck manchuck deleted the feat-jwt-signing branch August 21, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants