Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(voice): ncco encoding #906

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix(voice): ncco encoding #906

merged 1 commit into from
Jan 23, 2024

Conversation

manchuck
Copy link
Contributor

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05cbf33) 83.38% compared to head (b6acd55) 83.41%.

❗ Current head b6acd55 differs from pull request most recent head f2bdb27. Consider uploading reports for the commit f2bdb27 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              3.x     #906      +/-   ##
==========================================
+ Coverage   83.38%   83.41%   +0.03%     
==========================================
  Files         121      121              
  Lines        1637     1640       +3     
  Branches      323      324       +1     
==========================================
+ Hits         1365     1368       +3     
  Misses        272      272              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to the tests just to make sure everything is actually working

packages/voice/__tests__/__dataSets__/create.ts Outdated Show resolved Hide resolved
@manchuck manchuck merged commit 9f2cfc8 into 3.x Jan 23, 2024
13 checks passed
@manchuck manchuck deleted the fix-ncco-encoding branch January 23, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants