Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added RCS channel and changes to other channels #941

Merged
merged 6 commits into from
Jul 1, 2024

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Jun 20, 2024

Description

Adding the RCS Channel and syncing up MMS and SMS Channels

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.52%. Comparing base (e12c0d0) to head (a443216).
Report is 17 commits behind head on 3.x.

Current head a443216 differs from pull request most recent head 5a6a224

Please upload reports for the commit 5a6a224 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.x     #941      +/-   ##
==========================================
+ Coverage   84.36%   84.52%   +0.15%     
==========================================
  Files         122      130       +8     
  Lines        1797     1867      +70     
  Branches      375      382       +7     
==========================================
+ Hits         1516     1578      +62     
- Misses        281      289       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manchuck manchuck force-pushed the feat-message-updates branch 3 times, most recently from 8ebf6fd to 27e4e0f Compare June 21, 2024 14:55
@manchuck manchuck marked this pull request as ready for review June 21, 2024 14:57
packages/messages/README.md Outdated Show resolved Hide resolved
packages/messages/__tests__/__dataSets__/rcs.ts Outdated Show resolved Hide resolved
packages/messages/__tests__/__dataSets__/rcs.ts Outdated Show resolved Hide resolved
packages/messages/__tests__/__dataSets__/rcs.ts Outdated Show resolved Hide resolved
packages/messages/__tests__/__dataSets__/rcs.ts Outdated Show resolved Hide resolved
packages/messages/lib/types/MessageParamsAudio.ts Outdated Show resolved Hide resolved
packages/messages/lib/types/MessageParamsVcard.ts Outdated Show resolved Hide resolved
packages/messages/lib/types/MessageParamsVideo.ts Outdated Show resolved Hide resolved
packages/messages/lib/types/Requests/SMSMessageRequest.ts Outdated Show resolved Hide resolved
manchuck and others added 5 commits June 24, 2024 16:25
Updated the messages package to use new testing functions
Updated the messages package to use new testing functions
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Co-authored-by: Karl Lingiah <karl@superchilled.co.uk>
Copy link
Contributor

@superchilled superchilled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for addressing the comments.

@manchuck manchuck merged commit 4342a92 into 3.x Jul 1, 2024
13 checks passed
@manchuck manchuck deleted the feat-message-updates branch July 1, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants