fix: Add missing advanced machine detection mode #947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First of all, since this is my first PR in this repo, please correct and help by guiding me if I am wrong, thank you 🙇
Background of this PR is to add missing
default
enum forAdvancedMachineDetectionMode
Motivation and Context
According to the docs in here, there are 3 modes for Advanced Machine detection:
default
detect
detect_beep
However, the first one is missing from
AdvancedMachineDetectionMode
which means we are unable to use that mode using the provided SDK as-is. Please let me know if this is intentional because advanced machine detection is still in beta.Also I was unsure what to put as comment. According to documentation, the default value is
connect
(sync), and notdefault
(async), however when testing out without specifyingmode
, it sounded as if machine detection was async. So I am unsure whetherdefault
is actually default mode or not in the end.Testing Details
Sorry I was unable to add unit test as I am lacking knowledge of expected request and responses 🙇
Existing test are still passing.
Example Output or Screenshots (if appropriate)
https://developer.vonage.com/en/api/voice#createCall
Types of changes
Checklist