Feature/gnp number verification #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP * WIP * WIP * WIP * WIP * refactor to remove attempt at putting all event objects in * Added docs * phpstan fix number object
8.1 is minimum
* Big cleanup of unused internals * clean some unused imports * Fix baseline, mark some deprecations coming
Co-authored-by: yosh <yosh@latvm.unnamed.typo.pw>
* Finished GNP Auth and SimSwap MVP implementation * Add documentation * PSR-4 fix * clean imports * Finished GNP Auth and SimSwap MVP implementation * bring psr7 trait back (#482) * Fix broken git history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the work needed to implement Number Verification and SIMSwap GNP.
Description
This is a significant release in that it introduces some new classes and behaviour.
Firstly, it's worth noting that each API uses two different OAuth mechanisms, something that this SDK was not designed to do. From this perspective, the internals in order to be able to use them are somewhat against SOLID principals - each new API has it's own handler, and that handler behaves differently in each case.
Tech debt wise, this will be addressed with the introduction of PHP DI in v5.0 of this library.
The internals of this are not meant for developers to configure.
Motivation and Context
Evolution of Vonage PHP SDK
How Has This Been Tested?
Three new test suites have been added. One for the new type of OAuth handler, and one each for the new API clients.
Example Output or Screenshots (if appropriate):
Types of changes
Checklist: