Skip to content

Commit

Permalink
Fix ncco error (#238)
Browse files Browse the repository at this point in the history
* Bump version: 3.2.0 → 3.2.1

* fixing import issue with uncommitted init file

* adding check that subfolders contain an __init__.py file

* refactoring, raising exception
  • Loading branch information
maxkahan committed Jan 17, 2023
1 parent bfa6cb4 commit 1aefe00
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .bumpversion.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 3.2.0
current_version = 3.2.1
commit = True
tag = False

Expand Down
3 changes: 3 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 3.2.1
- Fixing an import bug

# 3.2.0
- Adding an NCCO Builder to make it easier to work with NCCOs when using the Voice API
- Individual NCCO Actions can be created as Pydantic models, which can be built into an NCCO via the `Ncco.build_ncco` method
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

setup(
name="vonage",
version="3.2.0",
version="3.2.1",
description="Vonage Server SDK for Python",
long_description=long_description,
long_description_content_type="text/markdown",
Expand Down
2 changes: 1 addition & 1 deletion src/vonage/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
from .client import *

__version__ = "3.2.0"
__version__ = "3.2.1"
Empty file.
12 changes: 12 additions & 0 deletions tests/test_packages.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import os


def test_subdirectories_are_python_packages():
subdirs = [
os.path.join('src/vonage', o) for o in os.listdir('src/vonage') if os.path.isdir(os.path.join('src/vonage', o))
]
for subdir in subdirs:
if '__pycache__' in subdir or os.path.isfile(f'{subdir}/__init__.py'):
continue
else:
raise Exception(f'Subfolder {subdir} doesn\'t have an __init__.py file')

0 comments on commit 1aefe00

Please sign in to comment.