Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify2 #254

Merged
merged 12 commits into from
May 16, 2023
Merged

Add verify2 #254

merged 12 commits into from
May 16, 2023

Conversation

maxkahan
Copy link
Collaborator

@maxkahan maxkahan commented Apr 12, 2023

This PR adds Verify V2 functionality to the SDK.

This includes

  • The v2 implementation for all channels
  • Bring your own pin
  • Fraud_check
  • Cancel request

@maxkahan maxkahan requested a review from SecondeJK April 12, 2023 02:33
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #254 (d62f157) into main (99b9635) will decrease coverage by 0.27%.
The diff coverage is 94.20%.

❗ Current head d62f157 differs from pull request most recent head 5921e4e. Consider uploading reports for the commit 5921e4e to get more accurate results

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   97.28%   97.01%   -0.27%     
==========================================
  Files          20       21       +1     
  Lines         737      805      +68     
==========================================
+ Hits          717      781      +64     
- Misses         20       24       +4     
Impacted Files Coverage Δ
src/vonage/verify.py 100.00% <ø> (ø)
src/vonage/client.py 94.38% <50.00%> (-1.91%) ⬇️
src/vonage/errors.py 100.00% <100.00%> (ø)
src/vonage/verify2.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxkahan
Copy link
Collaborator Author

Have added BYOP to this PR

@maxkahan maxkahan merged commit b3b5d34 into main May 16, 2023
@maxkahan maxkahan deleted the add-verify2 branch May 16, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants