Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding advancedMachineDetection to ncco builder and testing #259

Merged
merged 2 commits into from
May 16, 2023

Conversation

maxkahan
Copy link
Collaborator

This PR adds advancedMachineDetection to the NCCO builder. It's already possible in the SDK manually but this allows a user to use the feature in conjunction with the NCCO builder.

@codecov-commenter
Copy link

Codecov Report

Merging #259 (be341ce) into main (25f695e) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head be341ce differs from pull request most recent head 051be4f. Consider uploading reports for the commit 051be4f to get more accurate results

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   97.25%   97.30%   +0.04%     
==========================================
  Files          20       20              
  Lines         729      741      +12     
==========================================
+ Hits          709      721      +12     
  Misses         20       20              
Impacted Files Coverage Δ
src/vonage/ncco_builder/ncco.py 97.72% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxkahan maxkahan merged commit 99b9635 into main May 16, 2023
@maxkahan maxkahan deleted the add-advanced-machine-detection branch May 16, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants