Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GNP Sim Swap API #296

Merged
merged 5 commits into from
Jun 3, 2024
Merged

Add GNP Sim Swap API #296

merged 5 commits into from
Jun 3, 2024

Conversation

maxkahan
Copy link
Collaborator

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.44%. Comparing base (13808e1) to head (f7651bb).
Report is 10 commits behind head on main.

Current head f7651bb differs from pull request most recent head 1583769

Please upload reports for the commit 1583769 to get more accurate results.

Files Patch % Lines
src/vonage/camara_auth.py 93.75% 1 Missing ⚠️
src/vonage/sim_swap.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   97.27%   97.44%   +0.16%     
==========================================
  Files          25       28       +3     
  Lines        1102     1331     +229     
==========================================
+ Hits         1072     1297     +225     
- Misses         30       34       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxkahan maxkahan merged commit 11403f1 into main Jun 3, 2024
12 checks passed
@maxkahan maxkahan deleted the add-gnp branch June 3, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants