Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of T.nilable(T.untyped) #199

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Conversation

vinistock
Copy link
Contributor

Starting with sorbet/sorbet#5129, using T.nilable(T.untyped) is considered an error by Sorbet.

Starting with sorbet/sorbet#5129, using `T.nilable(T.untyped)` is considered an error by Sorbet.
@superchilled
Copy link
Contributor

Thanks for opening this PR @vinistock 🙂

It looks like a fairly straightforward change. I'll look at getting it merged and a patch release cut in the next day or two.

@superchilled superchilled self-requested a review February 15, 2022 14:30
@superchilled superchilled changed the base branch from 7.x to dev February 21, 2022 17:02
Copy link
Contributor

@superchilled superchilled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and all checks are passing.

@superchilled superchilled merged commit 49f3b3b into Vonage:dev Feb 22, 2022
@vinistock vinistock deleted the patch-1 branch February 22, 2022 16:27
@superchilled superchilled mentioned this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants