Clear cb labels when returning to pool (#1822)

* Default labels after using them * Move to just clearing labels for cb reduction
VowpalWabbit · Apr 4, 2019 · 5f7fcdb · 5f7fcdb
1 parent 7c221a4
commit 5f7fcdb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/vowpalwabbit/cb_explore_adf.cc b/vowpalwabbit/cb_explore_adf.cc
@@ -642,6 +642,12 @@ void finish_multiline_example(vw& all, cb_explore_adf& data, multi_ex& ec_seq)
     output_example_seq(all, data, ec_seq);
     CB_ADF::global_print_newline(all);
   }
+
+  for (auto x : ec_seq)
+  {
+    x->l.cb.costs.clear();
+  }
+
   VW::clear_seq_and_finish_examples(all, ec_seq);
 }
 

diff --git a/vowpalwabbit/parser.cc b/vowpalwabbit/parser.cc
@@ -854,7 +854,7 @@ void parse_example_label(vw& all, example& ec, string label)
   words.delete_v();
 }
 
-void empty_example(vw& /* all */, example& ec)
+void empty_example(vw& /*all*/, example& ec)
 {
   for (features& fs : ec) fs.clear();