Skip to content

Commit

Permalink
lint
Browse files Browse the repository at this point in the history
  • Loading branch information
bassmang committed Sep 29, 2023
1 parent a0630e2 commit 957db30
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
7 changes: 6 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,10 @@
],
"url": "./test/vwtest.schema.json"
}
]
],
"files.associations": {
"ranges": "cpp",
"bitset": "cpp",
"*.tcc": "cpp"
}
}
4 changes: 3 additions & 1 deletion vowpalwabbit/core/src/vw_validate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ void validate_num_bits(VW::workspace& all)
if (all.weights.sparse)
{
std::stringstream ss;
ss << "Bit size is " << all.initial_weights_config.num_bits << ". While this is allowed for sparse weights, it may cause an overflow and is strongly recommened to use a smaller value.";
ss << "Bit size is " << all.initial_weights_config.num_bits
<< ". While this is allowed for sparse weights, it may cause an overflow and is strongly recommened to use a "
"smaller value.";
all.logger.err_warn(ss.str());

Check failure on line 45 in vowpalwabbit/core/src/vw_validate.cc

View workflow job for this annotation

GitHub Actions / asan.ubuntu-latest.vcpkg-ubsan-debug

temporary of non-literal type ‘std::__cxx11::basic_stringstream<char>::__string_type’ {aka ‘std::__cxx11::basic_string<char>’} in a constant expression

Check failure on line 45 in vowpalwabbit/core/src/vw_validate.cc

View workflow job for this annotation

GitHub Actions / asan.ubuntu-latest.vcpkg-asan-debug

temporary of non-literal type ‘std::__cxx11::basic_stringstream<char>::__string_type’ {aka ‘std::__cxx11::basic_string<char>’} in a constant expression

Check failure on line 45 in vowpalwabbit/core/src/vw_validate.cc

View workflow job for this annotation

GitHub Actions / asan.windows-latest.vcpkg-asan-debug

'fmt::v9::basic_format_string<char>::basic_format_string': call to immediate function is not a constant expression
}
else
Expand Down

0 comments on commit 957db30

Please sign in to comment.