-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logistic regression C app stopped working between releases 8.5.0 and 8.6.0 #1780
Comments
I bisected to find that this stopped working with commit 276e0da. Unfortunately the commit message is simply "compiling". The changes seem to be related to "test labels" but I'm not familiar enough to understand what's going on. |
Thanks, that helps a great deal.
…On Tue, Mar 5, 2019 at 1:56 PM Jamie Markle ***@***.***> wrote:
I bisected to find that this stopped working with commit 276e0da
<276e0da>
.
Unfortunately the commit message is simply "compiling". The changes seem
to be related to "test labels" but I'm not familiar enough to understand
what's going on.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1780 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAE25nMyJ8CZ7HAhzaG09g0_rrcSKsJRks5vTr3qgaJpZM4bdNlZ>
.
|
I narrowed the changes down to one line.
was added to If I remove that line my example app seems to work properly again. I also tried applying the same change to release 8.6.1 and it also works there. |
Hi Jamie, |
note that removing the line above does cause |
So the problem that we are setting test_only = F1(all) | F2(label) inside setup_example, For resolving this particular problem, we can just recalculate test_only inside add_labels, but we need to add vw handle to signature in this case (to be able to get F1(all)): Also, seems like all label manipulations from setup_example have to be invalidated and re-done after each add_label call - we are also writing to cache inside setup_example, and it seems to be another bug for this scenario. |
Ah, ok. This should be easy to work around for my use case. I changed my example app to not use |
Yes, that's right - I need to think more how to fix it properly, but just avoiding AddLabel should work as workaround. |
@JohnLangford, do you have idea what should be the best fix here? I see several ways to workaround original issue:
|
|
Fixed in #1859 |
I wrote a small example C app to test logistic regression when linking against the C wrapper.
When I build and run using VW release 8.5.0 it seems to work properly and outputs
but when updating to 8.6.0 (or 8.6.1) the training doesn't seem to be happening:
Does anyone have a suggestion about the relevant changes between these releases? Looking at the the diffs of
vwdll.h
andvwdll.cpp
, I don't see any clues as to why this code would no longer work.The text was updated successfully, but these errors were encountered: