-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Still can't build statically on Linux #1831
Comments
Hi @arielf, I just looked into this and it seems like #1807 regressed this. Was a really simple typo that made it through. I've put out a PR to fix it. Here is the output for
|
Thanks @jackgerrits for the debug and quick fix. Highly appreciated! |
Sorry for that. Cmake is really weird :( |
No problem @kumpera . Thanks for all you work improving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Following the build instructions for static linking of vw
Don't end up with a statically linked executable in
build/vowpalwabbit/vw
To Reproduce
Steps to reproduce the behavior:
Outputs:
Expected behavior
file build/vowpalwabbit/vw
should say the executable isstatically linked
Observed Behavior
file build/vowpalwabbit/vw
says the executable isdynamically linked
Environment
What version of VW did you use? latest https://github.com/VowpalWabbit/vowpal_wabbit/ HEAD as of 2019-04-05
What OS or language did you use? Ubuntu 18.04, c++
Additional context
Related things I noticed:
Flags are sometimes specified as
On
and sometimes asON
in the CMakeLists.txt files and documentation. The cmake documentation like this seem to imply thatcmake
variables are case sensitive and the two are not the same. Changing everything toON
in my build tree, doesn't seem to be sufficient to fix the issue though.CMakeLists.txt
also defines a switchset(unix_static_flag -static)
but I'm not able to find where is this setting is being used.Several test/unit_test/*.cc files have:
Wouldn't this
ifndef
always be false, given that bothOFF
andON
define this variable?Is this mixing of C-preprocessor variables and Cmake variable a bug?
The text was updated successfully, but these errors were encountered: