[OSX] Improve support for static linking. #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On OSX, it's not possible to statically link against system libraries as they are closed source and Apple doesn't provide `.a` versions of them. So we do the best thing we can given those constraints. We fix the build and eliminate all dependencies we can. The resulting binaries should work on factory reset OSX machines, which is as good as we can aim for.
|
This fixes #1749 We must update the wiki page to include |
jackgerrits
pushed a commit
to jackgerrits/vowpal_wabbit
that referenced
this pull request
May 15, 2019
On OSX, it's not possible to statically link against system libraries as they are closed source and Apple doesn't provide `.a` versions of them. So we do the best thing we can given those constraints. We fix the build and eliminate all dependencies we can. The resulting binaries should work on factory reset OSX machines, which is as good as we can aim for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OSX, it's not possible to statically link against system libraries as they are closed source and Apple doesn't provide
.aversions of them.So we do the best thing we can given those constraints. We fix the build and eliminate all dependencies we can.
The resulting binaries should work on factory reset OSX machines, which is as good as we can aim for.