-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean windows build and unify output paths #1599
Clean windows build and unify output paths #1599
Conversation
92f8b06
to
f24967e
Compare
reinforcement_learning/examples/override_interface/override_interface.vcxproj
Show resolved
Hide resolved
test/unit_test/unit_test.vcxproj
Outdated
</ClCompile> | ||
<PostBuildEvent> | ||
<Command Condition="'$(Platform)'=='x64'">xcopy /Y ..\..\vowpalwabbit\packages\boost_unit_test_framework-vc140.1.63.0.0\lib\native\address-model-64\lib\*.dll $(OutDir)</Command> | ||
<Command Condition="'$(Platform)'=='x86'">xcopy /Y ..\..\vowpalwabbit\packages\boost_unit_test_framework-vc140.1.63.0.0\lib\native\address-model-32\lib\*.dll $(OutDir)</Command> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see platform x86 configured. I see Win32 and x64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
@lokitoth is this waiting on some updates from Rajan's comments? |
* The Azure projects are not well-maintained; they need retargetting / rethinking * The Setup project requires WiX installed, and this does not seem valuable to most people building VW
* This depends on VcpkgIntegration environment variable / project property set to the .targets file from msbuild integration: (VcPkgRoot)/scripts/buildsystems/msbuild/vcpkg.targets. If it is not present, the behaviour will be as before this change, demanding VS-level integration.
* Rename vw_dynamic => vw_core * Manually simplify the project and reconcile the outputs to $(SolutionDir)\out\<target\int>\... * Update dependent projects
* Enabled multi-threaded compilation * Also adds $(ProjectName) to int-path to avoid collisions
They do not currently build, and require an installed component to work properly.
* Update unittest project to pull the right package under x86 None of these change the behaviour of the build after the previous set of changes, just removes non-building projects: * Delete superfluous vcsproj files (for VLD integration) * Remove VLD package reference
f24967e
to
dd7751d
Compare
What's the status of this one? |
Ready to merge. |
* Remove Setup and Azure projects from solution * The Azure projects are not well-maintained; they need retargetting / rethinking * The Setup project requires WiX installed, and this does not seem valuable to most people building VW * Remove Azure dependency from C# Binding unit tests * Enable command-line msbuild for vcpkg-dependent projects * This depends on VcpkgIntegration environment variable / project property set to the .targets file from msbuild integration: (VcPkgRoot)/scripts/buildsystems/msbuild/vcpkg.targets. If it is not present, the behaviour will be as before this change, demanding VS-level integration. * Simplify and rename vs static library project * Rename vw_dynamic => vw_core * Manually simplify the project and reconcile the outputs to $(SolutionDir)\out\<target\int>\... * Update dependent projects * Simplify vw executable project * Enabled multi-threaded compilation * Also adds $(ProjectName) to int-path to avoid collisions * Fix "malformed xml in xmldoc comment" warning * Simplify libvw project file * Fix typo in vw exe project * Simplify c_test project * Simplify unit_test.vcxproj and unify output/intermediate paths * Add xcopy step to place boost unit test dll * Remove VisualLeakDetector-based projects They do not currently build, and require an installed component to work properly. * Simplify vw clr project and unify outputs * Remove unused deploy_vw project from build * Remove unused DebugLeakCheck configuration * Simplify C# projects and unify outputs * Update for PR comments * Update unittest project to pull the right package under x86 None of these change the behaviour of the build after the previous set of changes, just removes non-building projects: * Delete superfluous vcsproj files (for VLD integration) * Remove VLD package reference
This simplifies the Windows build