-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake build definitions #1624
CMake build definitions #1624
Conversation
I've updated the PR with the install step properly working now including:
I am not sure how to determine if this brings us to automake parity but after running make install the outputs are of almost the same structure (see .la note above). More testing is needed, but we are getting close to replacing 2 build systems with this change. |
- Add cmake support for Java and Python - Rewrite most of Python setup file for CMake
This pull request introduces 9 alerts when merging c0d19cb into a18d3ab - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 9 alerts when merging 437a1e1 into a18d3ab - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 6 alerts when merging 79b2887 into a18d3ab - view on LGTM.com new alerts:
Comment posted by LGTM.com |
Issues:
|
@@ -0,0 +1,55 @@ | |||
find_package(JNI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmorra @deaktator can you look at the cmake build for java here?
@@ -0,0 +1,36 @@ | |||
if(NOT DEFINED PY_VERSION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Scott-Graham-Bose This is the relevant bit for python build changes.
@@ -0,0 +1,53 @@ | |||
add_subdirectory(unit_test) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arielf These are the change to invocation of tests.
@eisber you may also be interested in this patch. |
I already skipped through ☺
Thanks
|
Disambiguators for else are not needed, they are used by CMake to warn if if-endifs do not match |
@JohnLangford I believe I have resolved the issues we came across today |
This pull request introduces 6 alerts when merging 8c1013e into 05cca52 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 6 alerts when merging 8537b54 into f11d323 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 6 alerts when merging 8537b54 into ad60f86 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 3 alerts when merging 7d1e2ff into 1ea72b2 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 3 alerts when merging 163c58f into acd910e - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 3 alerts when merging f9554f4 into 72f6f43 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 3 alerts when merging 75ee3d0 into fb8d488 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This PR add CMake build definitions. They do not include clr or csharp, but they do build on Windows and Linux. This attempt has gone down the route of as small a change as possible but still a step in the right direction.
Items still left to be done:
cmake --build
-- Not feasibleMore:
Fixes #1635