VS 2017 fixes #1628
Merged
VS 2017 fixes #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build is breaking. Fixable? |
|
LGTM |
|
@rajan-chari can you take a look? |
|
looking |
|
Looks good. Thanks. |
|
Merged, thanks :-) |
lokitoth
pushed a commit
to lokitoth/vowpal_wabbit
that referenced
this pull request
Dec 20, 2019
* remove main.cc from rlclientlib * update logic to enable SSE intrinsics * update logic handling shared variables across threads * fix build break where main.cc is missing * fix merge * fix gcc build break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix a compile issue on VS 2017 and fix some issues I noticed reviewing the code.