Ataymano/queue size control #1663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgerrits
approved these changes
Nov 1, 2018
| @@ -29,6 +30,7 @@ namespace reinforcement_learning { | |||
| if (!_queue.empty()) | |||
| { | |||
| *item = std::move(_queue.front()); | |||
| _capacity = (std::max)((int)0, (int)_capacity - (int)(item->size())); | |||
| @@ -29,6 +30,7 @@ namespace reinforcement_learning { | |||
| if (!_queue.empty()) | |||
| { | |||
| *item = std::move(_queue.front()); | |||
| _capacity = (std::max)((int)0, (int)_capacity - (int)(item->size())); | |||
There was a problem hiding this comment.
Use static_cast instead of c style casts
| @@ -29,6 +30,7 @@ namespace reinforcement_learning { | |||
| if (!_queue.empty()) | |||
| { | |||
| *item = std::move(_queue.front()); | |||
| _capacity = (std::max)((int)0, (int)_capacity - (int)(item->size())); | |||
There was a problem hiding this comment.
Why is the function name surrounded by parentheses?
|
|
||
| private: | ||
| //thread-unsafe | ||
| typename queue_t::iterator erase(typename queue_t::iterator it) { |
There was a problem hiding this comment.
create an alias for iterator_t to avoid having to use typename in the function signature
|
The reinforcement_learning directory has moved to its own repo. Can you please reopen this PR there? https://github.com/VowpalWabbit/reinforcement_learning |
|
Superseded by VowpalWabbit/reinforcement_learning#15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sampling based on queue capacity