Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export vw audit output to .tsv file #1677

Merged
merged 2 commits into from
Nov 10, 2018

Conversation

marco-rossi29
Copy link
Collaborator

No description provided.

@JohnLangford
Copy link
Member

This pull request introduces 1 alert when merging af29395 into 4bdbe69 - view on LGTM.com

new alerts:

  • 1 for Unused import

Comment posted by LGTM.com

@marco-rossi29
Copy link
Collaborator Author

marco-rossi29 commented Nov 8, 2018 via email

Copy link
Collaborator

@arielf arielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Marco

Thanks for writing/contributing this.

To make it more friendly to understand & use this, could you please:

  1. Add a hash-bang line #!... at the top (see other examples in the same dir)
  2. Rename the file to not have .py extension (the implementation language shouldn't matter in executables which have hash-bang line) and change the underscores in the name to dashes (doesn't require pressing SHIFT when typing the command). and finally make the name more descriptive (call it according to what this actually does) i.e in one step:
    git mv vw_audit_pp.py vw-audit2tsv
  3. Make it executable: chmod +x vw-audit2tsv

And recommit.

Now you should be able to call the utility directly without needing to type python in front, or use SHIFT for some chars.

Thanks again

@arielf arielf merged commit a8afec8 into VowpalWabbit:master Nov 10, 2018
@marco-rossi29 marco-rossi29 deleted the marossi/audit_pp branch November 30, 2018 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants