Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable selective CMake configuration, improve messaging #1678

Merged
merged 4 commits into from
Nov 13, 2018

Conversation

jackgerrits
Copy link
Member

@jackgerrits jackgerrits commented Nov 12, 2018

Adds CMake options which allows for enabling and disabling several parts of the codebase. This makes for for faster configuration and the ability to ignore sections which you don't have the dependencies installed. Necessary to be consumed as a submodule easily.

Fixes #1674

@JohnLangford
Copy link
Member

This pull request fixes 1 alert when merging a2f1fb9 into a8afec8 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

Comment posted by LGTM.com

@JohnLangford
Copy link
Member

This pull request fixes 1 alert when merging f0fa469 into a8afec8 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

Comment posted by LGTM.com

Copy link
Member

@lokitoth lokitoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ship it.

@JohnLangford
Copy link
Member

This pull request fixes 1 alert when merging 0e04823 into 7222467 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

Comment posted by LGTM.com

@lokitoth lokitoth merged commit fdc1476 into VowpalWabbit:master Nov 13, 2018
@jackgerrits jackgerrits deleted the jagerrit/modular_build branch January 15, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants