-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vw java 11 compatibility #1700
vw java 11 compatibility #1700
Conversation
comment out docs maven-compiler plugin change version
Thanks for submitting a patch! Just two things, this needs to be up to date with master before CI will run. Also, does this break backwards compatibility with other versions of Java? |
@josepowera can you update the pom.xml file? |
I really want to see this change in, can you move the changes from |
@deaktator @jon-morra-zefr any comments on this? We are likely to merge some version of this shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@JohnLangford once CI passes this should be good to go. |
Merged, thanks :-) |
RunTests: use test label number instead of counter (VowpalWabbit/vowpal_wabbit#1753) Small Json parser cleanup (VowpalWabbit/vowpal_wabbit#1759) Type erase json parser context for easier deletion ((VowpalWabbit/vowpal_wabbit#1760) Fix static linking (VowpalWabbit/vowpal_wabbit#1758) Fix build scripts forcing Debug builds. Add LTO mode and fix VW defau…(VowpalWabbit/vowpal_wabbit#1735) Do not define BOOST_TEST_DYN_LINK when statically linking (VowpalWabbit/vowpal_wabbit#1750) Convert TopK reduction to be multiline example based (VowpalWabbit/vowpal_wabbit#1752) vw java 11 compatibility (VowpalWabbit/vowpal_wabbit#1700) cbify: --cbify_ldf for multiline (csoaa_ldf) input datasets (VowpalWabbit/vowpal_wabbit#1681) Merge pull request #1751 from yannstad/fix-tests (VowpalWabbit/vowpal_wabbit#1751) [tests] Make repeat.py compatible with python 3 (VowpalWabbit/vowpal_wabbit#1747)
* java11 compatibility comment out docs maven-compiler plugin change version * test with javadoc enabled * update javadoc * Fix extra spaces
Fixes #1610