vw java 11 compatibility #1700
Merged
vw java 11 compatibility #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comment out docs maven-compiler plugin change version
|
Thanks for submitting a patch! Just two things, this needs to be up to date with master before CI will run. Also, does this break backwards compatibility with other versions of Java? |
jackgerrits
reviewed
Jan 2, 2019
|
@josepowera can you update the pom.xml file? |
|
I really want to see this change in, can you move the changes from |
|
@deaktator @jon-morra-zefr any comments on this? We are likely to merge some version of this shortly. |
|
@JohnLangford once CI passes this should be good to go. |
|
Merged, thanks :-) |
rajan-chari
pushed a commit
to VowpalWabbit/reinforcement_learning
that referenced
this pull request
Feb 22, 2019
RunTests: use test label number instead of counter (VowpalWabbit/vowpal_wabbit#1753) Small Json parser cleanup (VowpalWabbit/vowpal_wabbit#1759) Type erase json parser context for easier deletion ((VowpalWabbit/vowpal_wabbit#1760) Fix static linking (VowpalWabbit/vowpal_wabbit#1758) Fix build scripts forcing Debug builds. Add LTO mode and fix VW defau…(VowpalWabbit/vowpal_wabbit#1735) Do not define BOOST_TEST_DYN_LINK when statically linking (VowpalWabbit/vowpal_wabbit#1750) Convert TopK reduction to be multiline example based (VowpalWabbit/vowpal_wabbit#1752) vw java 11 compatibility (VowpalWabbit/vowpal_wabbit#1700) cbify: --cbify_ldf for multiline (csoaa_ldf) input datasets (VowpalWabbit/vowpal_wabbit#1681) Merge pull request #1751 from yannstad/fix-tests (VowpalWabbit/vowpal_wabbit#1751) [tests] Make repeat.py compatible with python 3 (VowpalWabbit/vowpal_wabbit#1747)
jackdoe
pushed a commit
to lucjb/vowpal_wabbit
that referenced
this pull request
Mar 7, 2019
* java11 compatibility comment out docs maven-compiler plugin change version * test with javadoc enabled * update javadoc * Fix extra spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1610