Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

options_i command line parsing refactor #1706

Merged
merged 69 commits into from
Jan 16, 2019
Merged

options_i command line parsing refactor #1706

merged 69 commits into from
Jan 16, 2019

Commits on Dec 17, 2018

  1. Initial framework commit of options refactor

    @jackgerrits
    jackgerrits committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    dbf5dee View commit details
    Browse the repository at this point in the history

  2. Rename options -> arguments, option -> parameter

    @jackgerrits
    jackgerrits committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    45627b0 View commit details
    Browse the repository at this point in the history

  3. equality unit test

    @jackgerrits
    jackgerrits committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    2e4d6fb View commit details
    Browse the repository at this point in the history

  4. Working on tests

    @jackgerrits
    jackgerrits committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    aa35d8a View commit details
    Browse the repository at this point in the history

  5. Add kept implementation

    @jackgerrits
    jackgerrits committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    f20f73d View commit details
    Browse the repository at this point in the history

  6. revert line ending change

    @jackgerrits
    jackgerrits committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    8b3dacc View commit details
    Browse the repository at this point in the history

  7. Update cmake and fix build

    @jackgerrits
    jackgerrits committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    b12c3a9 View commit details
    Browse the repository at this point in the history

  8. Update arg to hold value, expose arg list and merging

    @jackgerrits
    jackgerrits committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    a53364f View commit details
    Browse the repository at this point in the history

  9. Rename arguments to options

    @jackgerrits
    jackgerrits committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    f317655 View commit details
    Browse the repository at this point in the history

  10. rename files arguments -> options

    @jackgerrits
    jackgerrits committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    196af06 View commit details
    Browse the repository at this point in the history

  11. Add config namespace

    @jackgerrits
    jackgerrits committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    c548106 View commit details
    Browse the repository at this point in the history

  12. Change back to non-duplicates and use references

    @jackgerrits
    jackgerrits committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    f2d8da8 View commit details
    Browse the repository at this point in the history

  13. Migration progress: 

    initialize
  parse_args DONE
    parse_diagnostics DONE
  parse_regressor_args
  parse_modules
    save_load_header (hard)
    check_interaction_settings_collision
    parse_feature_tweaks
    parse_example_tweaks
    parse_output_model
    parse_output_preds
    parse_reductions (large surface)
  parse_sources
    load_input_model
      parse_mask_regressor_args
        TODO clear file options
    parse_source (positional param) DONE
    enable_sources DONE
      parse_cache DONE
all reductions
    @jackgerrits
    jackgerrits committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    9d443d1 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2018

  1. Migrate model header load 

    Migration progress:
initialize
  parse_args DONE
    parse_diagnostics DONE
  parse_regressor_args
  parse_modules
    save_load_header (hard) DONE
    check_interaction_settings_collision DONE
    parse_feature_tweaks
    parse_example_tweaks
    parse_output_model
    parse_output_preds
    parse_reductions (large surface)
  parse_sources
    load_input_model
      parse_mask_regressor_args
        TODO clear file options
    parse_source (positional param) DONE
    enable_sources DONE
      parse_cache DONE
all reductions
    @jackgerrits
    jackgerrits committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    056081e View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2018

  1. Migrate parse_feature_tweaks

    @jackgerrits
    jackgerrits committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    19f6087 View commit details
    Browse the repository at this point in the history

  2. migrate parse_example_tweaks

    @jackgerrits
    jackgerrits committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    5e9951e View commit details
    Browse the repository at this point in the history

  3. migrate parse_output_model and parse_output_preds

    @jackgerrits
    jackgerrits committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    ddb0222 View commit details
    Browse the repository at this point in the history

  4. Change to using reference instead of pointer for options object

    @jackgerrits
    jackgerrits committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    bd42a7e View commit details
    Browse the repository at this point in the history

  5. Migrate marginal reduction

    @jackgerrits
    jackgerrits committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    212f57e View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2018

  1. Change all signatures to include options_i and vw

    @jackgerrits
    jackgerrits committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    201f34a View commit details
    Browse the repository at this point in the history

  2. migrate gd

    @jackgerrits
    jackgerrits committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    de0408f View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2018

  1. Migrate kernel svm and fix keep arg in marginal

    @jackgerrits
    jackgerrits committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    3be311e View commit details
    Browse the repository at this point in the history

  2. migrate ftrl reduction

    @jackgerrits
    jackgerrits committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    020325c View commit details
    Browse the repository at this point in the history

  3. migrate svrg reduction

    @jackgerrits
    jackgerrits committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    c4ebae5 View commit details
    Browse the repository at this point in the history

  4. migrate sender

    @jackgerrits
    jackgerrits committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    7982425 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2019

  1. migrate gd_mf

    @jackgerrits
    jackgerrits committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    969ddd7 View commit details
    Browse the repository at this point in the history

  2. work in progress

    @jackgerrits
    jackgerrits committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    3c88834 View commit details
    Browse the repository at this point in the history

  3. Update loss_function to be able to dynamically identify type

    @jackgerrits
    jackgerrits committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    1225797 View commit details
    Browse the repository at this point in the history

  4. work in progress

    @jackgerrits
    jackgerrits committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    34f967a View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. Finish migrating reductions, and search tasks

    @jackgerrits
    jackgerrits committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    8defa86 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2019

  1. fix compile issues in vw_core

    @jackgerrits
    jackgerrits committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    e0dc05d View commit details
    Browse the repository at this point in the history

  2. working through test fixes

    @jackgerrits
    jackgerrits committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    86126ff View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2019

  1. fix bugs

    @jackgerrits
    jackgerrits committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    ed66172 View commit details
    Browse the repository at this point in the history

  2. Fix bug, update test model file

    @jackgerrits
    jackgerrits committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    6e8a7e6 View commit details
    Browse the repository at this point in the history

  3. Fix tests, update cppcli wrapper, update c# unit tests, fix c# versio… 

    …ns, remove parser_helper
    @jackgerrits
    jackgerrits committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    c2204c4 View commit details
    Browse the repository at this point in the history

  4. Fix help printout, unregistered options check

    @jackgerrits
    jackgerrits committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    7a1d2be View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2019

  1. merge conflicts

    @jackgerrits
    jackgerrits committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    8a82af8 View commit details
    Browse the repository at this point in the history

  2. Fix options leaked object

    @jackgerrits
    jackgerrits committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    0b9fb19 View commit details
    Browse the repository at this point in the history

  3. remove width of print for older boost version

    @jackgerrits
    jackgerrits committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    02045b1 View commit details
    Browse the repository at this point in the history

  4. update usage of options in python and remove program_options referenc… 

    …e in Java
    @jackgerrits
    jackgerrits committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    b52586e View commit details
    Browse the repository at this point in the history

  5. add move constructor, fix onethread unregistered issue and fix false … 

    …negative unrecognized args
    @jackgerrits
    jackgerrits committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    25628da View commit details
    Browse the repository at this point in the history

  6. try not using move constructors

    @jackgerrits
    jackgerrits committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    bb2fa9e View commit details
    Browse the repository at this point in the history

  7. move to a unique ptr to deal with gcc4.9

    @jackgerrits
    jackgerrits committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    7f006c1 View commit details
    Browse the repository at this point in the history

  8. fix save resume

    @jackgerrits
    jackgerrits committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    cd07648 View commit details
    Browse the repository at this point in the history

  9. trigger ci

    @jackgerrits
    jackgerrits committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    bf8b3f1 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2019

  1. implement positional parameter for data and revert test changes

    @jackgerrits
    jackgerrits committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    3f7cf1a View commit details
    Browse the repository at this point in the history

  2. properly handle invalid args for Java

    @jackgerrits
    jackgerrits committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    d3bf228 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2019

  1. fix writing if incorrect cb_type to model

    @jackgerrits
    jackgerrits committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    ba475f7 View commit details
    Browse the repository at this point in the history

  2. fix --opt=val style parsing from model file args

    @jackgerrits
    jackgerrits committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    78c7f2a View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2019

  1. change handling of defaults for cb_type, change insert behavior for e… 

    …mpty value string
    @jackgerrits
    jackgerrits committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    861fd81 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into jagerrit/migrate_options

    @jackgerrits
    jackgerrits committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    13de7d8 View commit details
    Browse the repository at this point in the history

  3. Fix merge conflict, kvm loss function check is fixed in this PR

    @jackgerrits
    jackgerrits committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    31a001c View commit details
    Browse the repository at this point in the history

  4. revert unwanted changes

    @jackgerrits
    jackgerrits committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    cb0b7c0 View commit details
    Browse the repository at this point in the history

  5. revert Resource.rc removal

    @jackgerrits
    jackgerrits committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    1aaafe7 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. revert adding include

    @jackgerrits
    jackgerrits committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    533f101 View commit details
    Browse the repository at this point in the history

  2. fix kernel_svn -> kernel_svm

    @jackgerrits
    jackgerrits committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    a5528b7 View commit details
    Browse the repository at this point in the history

  3. Use const& for strings and larger objects in options

    @jackgerrits
    jackgerrits committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    0ef8449 View commit details
    Browse the repository at this point in the history

  4. Fix lgtm alert about copy assignment operator

    @jackgerrits
    jackgerrits committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    8a0679c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into jagerrit/migrate_options

    @jackgerrits
    jackgerrits authored Jan 14, 2019
    Configuration menu
    Copy the full SHA
    9e10531 View commit details
    Browse the repository at this point in the history

  6. add back <algorithm> for min/max

    @jackgerrits
    jackgerrits committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    0bea867 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2019

  1. using namespace VW::config;

    @jackgerrits
    jackgerrits committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    4dec969 View commit details
    Browse the repository at this point in the history

  2. fix java dependencies, update cpprestsdk build

    @jackgerrits
    jackgerrits committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    89b5959 View commit details
    Browse the repository at this point in the history

  3. Revert "fix java dependencies, update cpprestsdk build" 

    This reverts commit 89b5959.
    @jackgerrits
    jackgerrits committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    9b5215c View commit details
    Browse the repository at this point in the history

  4. return reference from, rename make function

    @jackgerrits
    jackgerrits committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    6d9cae3 View commit details
    Browse the repository at this point in the history

  5. remove options.cc

    @jackgerrits
    jackgerrits committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    f3b022b View commit details
    Browse the repository at this point in the history

  6. use given reference for setup_base

    @jackgerrits
    jackgerrits committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    dce63d8 View commit details
    Browse the repository at this point in the history

  7. remove fields from all

    @jackgerrits
    jackgerrits committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    fa7f6d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. Merge branch 'master' into jagerrit/migrate_options

    @jackgerrits
    jackgerrits authored Jan 16, 2019
    Configuration menu
    Copy the full SHA
    9337bed View commit details
    Browse the repository at this point in the history

  2. merge commit

    @jackgerrits
    jackgerrits committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    2e32eb7 View commit details
    Browse the repository at this point in the history