Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invert_hash with json input #1711

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Fix invert_hash with json input #1711

merged 1 commit into from
Jan 15, 2019

Conversation

jackgerrits
Copy link
Member

When creating the json parser, the audit template parameter must be true to generate the information required by --invert_hash.

Fixes #1614

@JohnLangford JohnLangford merged commit 6dbb7e5 into VowpalWabbit:master Jan 15, 2019
@JohnLangford
Copy link
Member

Merged thanks :-)

@JohnLangford JohnLangford mentioned this pull request Jan 16, 2019
Merged
jackdoe pushed a commit to lucjb/vowpal_wabbit that referenced this pull request Mar 7, 2019
@jackgerrits
Add check for hash_inv when creating json parser (VowpalWabbit#1711)
95260b8
@jackgerrits jackgerrits deleted the jagerrit/fix_invert branch April 5, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackgerrits @JohnLangford