-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to std types for concurrency #1731
Merged
JohnLangford
merged 9 commits into
VowpalWabbit:master
from
jackgerrits:jagerrit/std_multithreading
Jan 30, 2019
Merged
Move to std types for concurrency #1731
JohnLangford
merged 9 commits into
VowpalWabbit:master
from
jackgerrits:jagerrit/std_multithreading
Jan 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n CLR mode, should probably use pimpl pattern
This actually contains a regression, I think a deadlock. I'm going to close it until I get time to figure it out |
kumpera
reviewed
Jan 29, 2019
lokitoth
reviewed
Jan 29, 2019
This seems like a clear win from a code complexity and dependency standpoint. Let's merge after addressing minor comments. |
jackdoe
pushed a commit
to lucjb/vowpal_wabbit
that referenced
this pull request
Mar 7, 2019
* change to std datatypes for multithreading. Still need to fix usage in CLR mode, should probably use pimpl pattern * Fix concurrency classes for managed cpp * unwind recursive call and fix deadlock * Address comments * Add comment * Add back required undef and define
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1725
std::thread
,std::condition_variable
andstd::mutex