Fix a small issue and cleanup usage of long long #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokitoth
requested changes
Jan 29, 2019
kumpera
force-pushed
the
fix_more_warnings
branch
from
3930832
to
fccfb8d
Compare
lokitoth
approved these changes
Jan 29, 2019
|
Looks good to go to me. |
Good catch! It was a mistake on my end. Removed it from the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue in python bindings revealed by a warning (implicit cast from 64 to 32 bits int).
Remove usage of
long longin favor of int64_t. The code base uses both and the later is both shorter and is more intuitive.