Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On OSX, we need to catch boost::program_options::ambiguous_option directly. Probably due to different boost versions. #1776

Merged
merged 1 commit into from
Feb 28, 2019
Merged

On OSX, we need to catch boost::program_options::ambiguous_option directly. Probably due to different boost versions. #1776

merged 1 commit into from
Feb 28, 2019

Conversation

kumpera
Copy link
Collaborator

@kumpera kumpera commented Feb 27, 2019

This fixes 1/3 of the errors in #1746.

@kumpera
On OSX, we need to catch boost::program_options::ambiguous_option dir…
99d826c 
…ectly. Probably due to different boost versions.
@kumpera kumpera mentioned this pull request Feb 27, 2019
Closed
@kumpera kumpera merged commit 018dbd1 into VowpalWabbit:master Feb 28, 2019
@kumpera kumpera deleted the fix_unit_test_on_osx branch February 28, 2019 17:53
@kumpera kumpera mentioned this pull request Mar 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackgerrits jackgerrits jackgerrits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumpera @jackgerrits