[audit] Make sure --audit output is reproducible across systems. #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interactions output was using std::sort which triggered issues when values were the same.
|
This fixes a bug I found while working on #1746 |
jackgerrits
approved these changes
Mar 13, 2019
|
This looks good, but appveyor is barfing on 176? |
|
Investigating it next. |
arielf
approved these changes
Mar 15, 2019
|
The appveyor failure was due to some technical debt in our test harness. I added an issue to track this: #1803 |
jackgerrits
pushed a commit
to jackgerrits/vowpal_wabbit
that referenced
this pull request
May 15, 2019
…palWabbit#1788) * [audit] Make sure --audit output is reproducible across systems. Interactions output was using std::sort which triggered issues when values were the same. * [unitest] Disable acceptance test that can't be processed by RunTests.tt * [tests] Disable 176 as well since it was being silently ignored until 177 was added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interactions output was using std::sort which triggered issues when values were the same.