expand Boost_LIBRARIES for pkg-config libs #1801
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest cmake build process the installed file
libvw.pc
contains all the required boost libraries in a semicolon-separated list. This causes the output ofpkg-config --libs libvw
on Ubuntu 18.04 to be:which is not useful for passing to the linker.
This change separates the library paths with spaces so that a command such as
g++ $(pkg-config --libs libvw) ...
can work.There might be a better, more idiomatic cmake way to fix this.