Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable JSON example parsing in Python bindings #1809

Merged
merged 6 commits into from
Mar 29, 2019
Merged

Enable JSON example parsing in Python bindings #1809

merged 6 commits into from
Mar 29, 2019

Conversation

jackgerrits
Copy link
Member

  • Remove learn_string and predict_string
  • Add new parse logic to include multiline and json
  • Add parse method to vw class for general parsing
  • Add new function pointer for line -> example[]

Fixes #1756

@jackgerrits jackgerrits mentioned this pull request Mar 26, 2019
Closed
lokitoth
lokitoth approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@lokitoth lokitoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I will stage the hook_task PR for after this one. Approving now, but please take a look at the comments.

python/pylibvw.cc Show resolved Hide resolved
python/vowpalwabbit/pyvw.py Outdated Show resolved Hide resolved
vowpalwabbit/parse_example.cc Show resolved Hide resolved
@jackgerrits
Copy link
Member Author

@Scott-Graham-Bose if you have a chance it would be good to get your review on this

@jackgerrits jackgerrits merged commit d4cac03 into VowpalWabbit:master Mar 29, 2019
@jackgerrits jackgerrits mentioned this pull request Mar 29, 2019
Merged
@jackgerrits jackgerrits deleted the jagerrit/python_json branch April 5, 2019 16:21
@marco-rossi29 marco-rossi29 mentioned this pull request Apr 18, 2019
Closed
jackgerrits added a commit to jackgerrits/vowpal_wabbit that referenced this pull request May 15, 2019
@jackgerrits
Enable JSON example parsing in Python bindings (VowpalWabbit#1809)
1c6bec8 
* Add text_reader, enable json parsing in python bindings

* Strip \r, raise error on len > 1 single examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokitoth lokitoth lokitoth approved these changes

@ataymano ataymano Awaiting requested review from ataymano

Assignees
No one assigned
Labels
Lang: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackgerrits @lokitoth