-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable JSON example parsing in Python bindings #1809
Merged
jackgerrits
merged 6 commits into
VowpalWabbit:master
from
jackgerrits:jagerrit/python_json
Mar 29, 2019
Merged
Enable JSON example parsing in Python bindings #1809
jackgerrits
merged 6 commits into
VowpalWabbit:master
from
jackgerrits:jagerrit/python_json
Mar 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokitoth
approved these changes
Mar 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I will stage the hook_task PR for after this one. Approving now, but please take a look at the comments.
jackgerrits
force-pushed
the
jagerrit/python_json
branch
from
March 26, 2019 18:50
3ac3827
to
f4dfbac
Compare
lokitoth
approved these changes
Mar 26, 2019
@Scott-Graham-Bose if you have a chance it would be good to get your review on this |
jackgerrits
added a commit
to jackgerrits/vowpal_wabbit
that referenced
this pull request
May 15, 2019
* Add text_reader, enable json parsing in python bindings * Strip \r, raise error on len > 1 single examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1756