Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build scripts for python3 on linux #1823

Merged
merged 5 commits into from
Apr 10, 2019

Conversation

peterychang
Copy link
Collaborator

No description provided.

@peterychang peterychang changed the title Fix build scripts for python3 Fix build scripts for python3 on linux Apr 5, 2019
@peterychang
Copy link
Collaborator Author

Fix confirmed Python2.7 on Boost1.64, python3.6 on Boost1.64, and python3.7 on Boost1.67

@peterychang
Copy link
Collaborator Author

peterychang commented Apr 5, 2019

Found a bug with python 2.7 and boost 1.67
Ignore that last comment, it was boost that didn't build correctly. 2.7 builds on Boost 1.64 and 1.67

@jackgerrits jackgerrits merged commit d55d83c into VowpalWabbit:master Apr 10, 2019
@jackgerrits
Copy link
Member

Thanks!

@n17s
Copy link
Contributor

n17s commented Apr 17, 2019

This fixed my issues with successfully compiling but not being able to import pyvw (tested on python 3.7 and boost 1.68)

@peterychang
Copy link
Collaborator Author

@n17s what is the error you're getting?

jackgerrits pushed a commit to jackgerrits/vowpal_wabbit that referenced this pull request May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants