Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement finish_example, update scripts to match #1837

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Implement finish_example, update scripts to match #1837

merged 3 commits into from
Apr 30, 2019

Conversation

jackgerrits
Copy link
Member

  • Implements finish_example
  • Required an interface change because example and multi_ex must be treated differently and so the single Python example object can no longer expose the ability to finish directly. (Calling finish on a single example in a multi_ex will not work)

Fixes #1810

@peterychang
Copy link
Collaborator

lgtm

@jackgerrits
Copy link
Member Author

@Scott-Graham-Bose if you have a chance to review that would be good

@jackgerrits jackgerrits merged commit f159ff6 into VowpalWabbit:master Apr 30, 2019
@jackgerrits jackgerrits deleted the jagerrit/implement_example_finish_python branch May 8, 2019 18:30
jackgerrits added a commit to jackgerrits/vowpal_wabbit that referenced this pull request May 15, 2019
@jackgerrits
Implement finish_example, update scripts to match (VowpalWabbit#1837)
1fa72d3
This was referenced Dec 4, 2019
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Lang: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement example.finish in Python bindings
2 participants
@jackgerrits @peterychang