cb_adf and cb_explore_adf: Setting --cb_type mtr as default #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackgerrits I discussed with @JohnLangford to make |
|
Update the tests. Note that RunTests has a flag to do this.
…-John
On Wed, Apr 10, 2019 at 7:41 PM Marco Rossi ***@***.***> wrote:
@jackgerrits <https://github.com/jackgerrits> I discussed with
@JohnLangford <https://github.com/JohnLangford> to make mtr the default
cb_type. Some tests are failing since we change the default behavior. How
do you suggest to proceed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1838 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAE25vCft3t1N5yzne4BijobXZKKz-xtks5vfnafgaJpZM4cocaj>
.
|
|
cb_algs.cc contains a default of |
|
mtr does not exist for non-adf. |
|
In that case should cb_explore_adf.cc be |
marco-rossi29
changed the title
marco-rossi29
force-pushed
the
marco-rossi29/default_cb_type_mtr
branch
from
93e84e8
to
bf9934a
Compare
marco-rossi29
force-pushed
the
marco-rossi29/default_cb_type_mtr
branch
from
a6ae157
to
e25bc79
Compare
marco-rossi29
force-pushed
the
marco-rossi29/default_cb_type_mtr
branch
from
e25bc79
to
53ac796
Compare
|
I fixed all the errors in RunTests. However, now Travis is failing on Java Tests. @JohnLangford Is the a simple flag for the Java tests? |
|
I don't think so. |
marco-rossi29
force-pushed
the
marco-rossi29/default_cb_type_mtr
branch
3 times, most recently
from
f552b1a
to
53ac796
Compare
marco-rossi29
force-pushed
the
marco-rossi29/default_cb_type_mtr
branch
from
53ac796
to
822158d
Compare
|
This PR is blocked on LGTM failing Java analysis for VW master (I've on purpose placed a dummy change in the help section of cb_explore_adf.cc) |
marco-rossi29
force-pushed
the
marco-rossi29/default_cb_type_mtr
branch
from
9208659
to
f552b1a
Compare
marco-rossi29
force-pushed
the
marco-rossi29/default_cb_type_mtr
branch
from
f552b1a
to
c0f7471
Compare
|
@marco-rossi29 tests are now passing |
|
This is ready to be squashed-merged! |
|
Thanks Marco! |
jackgerrits
pushed a commit
to jackgerrits/vowpal_wabbit
that referenced
this pull request
May 15, 2019
…bbit#1838) * cb_adf: Setting --cb_type mtr as default * cb_explore_adf.cc: default cb_type mtr * Removed dm from cb_type help, since dm is not supported * Fixed test 84 * cb_adf: fixed test 87 * cb_explore_adf: Fixed test 129 * cb_explore_adf: Fixed test 138 * cb_explore_adf: Fixed test 158 * Fixing Java tests errors * Update tests * Precision * Precision * ordering * precision * Fix ips->mtr in comment + adding spaces in cmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.