-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cb_adf and cb_explore_adf: Setting --cb_type mtr as default #1838
Conversation
@jackgerrits I discussed with @JohnLangford to make |
Update the tests. Note that RunTests has a flag to do this.
…-John
On Wed, Apr 10, 2019 at 7:41 PM Marco Rossi ***@***.***> wrote:
@jackgerrits <https://github.com/jackgerrits> I discussed with
@JohnLangford <https://github.com/JohnLangford> to make mtr the default
cb_type. Some tests are failing since we change the default behavior. How
do you suggest to proceed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1838 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAE25vCft3t1N5yzne4BijobXZKKz-xtks5vfnafgaJpZM4cocaj>
.
|
cb_algs.cc contains a default of |
mtr does not exist for non-adf. |
In that case should cb_explore_adf.cc be |
93e84e8
to
bf9934a
Compare
a6ae157
to
e25bc79
Compare
e25bc79
to
53ac796
Compare
I fixed all the errors in RunTests. However, now Travis is failing on Java Tests. @JohnLangford Is the a simple flag for the Java tests? |
I don't think so. |
f552b1a
to
53ac796
Compare
53ac796
to
822158d
Compare
This PR is blocked on LGTM failing Java analysis for VW master (I've on purpose placed a dummy change in the help section of cb_explore_adf.cc) |
9208659
to
f552b1a
Compare
f552b1a
to
c0f7471
Compare
@marco-rossi29 tests are now passing |
This is ready to be squashed-merged! |
Thanks Marco! |
…bbit#1838) * cb_adf: Setting --cb_type mtr as default * cb_explore_adf.cc: default cb_type mtr * Removed dm from cb_type help, since dm is not supported * Fixed test 84 * cb_adf: fixed test 87 * cb_explore_adf: Fixed test 129 * cb_explore_adf: Fixed test 138 * cb_explore_adf: Fixed test 158 * Fixing Java tests errors * Update tests * Precision * Precision * ordering * precision * Fix ips->mtr in comment + adding spaces in cmd
No description provided.