cleaning up broken python3 vcxproj files #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgerrits
reviewed
Apr 30, 2019
python/README.rst
Outdated
| > python setup.py --vcpkg-root=[vcpkg-dir] install | ||
|
|
||
| .. _experimental Windows CMake build: https://github.com/VowpalWabbit/vowpal_wabbit/blob/master/README.Windows.md#experimental-cmake-build |
There was a problem hiding this comment.
It would be better to link here: https://github.com/VowpalWabbit/vowpal_wabbit/wiki/Dependencies#experimental-cmake-build-system-on-windows
|
This seems like a good opportunity for us to contribute to vcpkg, the change seems easy and it will help us a lot here |
…al_wabbit into python3_windows_cleanup
This reverts commit d474b3e.
|
Looks like the failures are due to the fact the submodule was removed in the merge |
jackgerrits
pushed a commit
to jackgerrits/vowpal_wabbit
that referenced
this pull request
May 15, 2019
* cleaning up broken python3 vcxproj files * Update URL to wiki instead of README * merging with master * Revert "merging with master" This reverts commit d474b3e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm leaving in the python27 vcxproj files since the CMake/vcpkg method requires a manual edit of a vcpkg CONTROL file.
microsoft/vcpkg#3495
I'll remove the old workflow once I can find a programmatic way of handling it