BF: add cmake to installed dependencies in unstable singularity images #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for updating this! Will merge once checks finish. |
|
AFAIK Travis checks the merged state, and since there were no conflicts no explicit merge was needed, but no harm is done ;-) |
|
Just needed to update as we require branches to be up to date before merging, and tests pass with the merged code. Not relevant here as the checks don’t touch the files changed, but had to satisfy the policy 😄 |
jackgerrits
pushed a commit
to jackgerrits/vowpal_wabbit
that referenced
this pull request
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1553 for the initial "motivation"