Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Version and Tag override for NuGet pack #1870

Merged
merged 2 commits into from
May 10, 2019
Merged

Enable Version and Tag override for NuGet pack #1870

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e710dd9
Enable Version and Tag override for NuGet pack
lokitoth May 9, 2019
a5595e9
Add a reference to tracking issue in todo
lokitoth May 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pipelines/build-windows-nuget.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ steps:
- script: CALL .scripts/package.cmd
displayName: 'Package artifacts'
env:
Tag: +$(Build.SourceVersion)
Tag: -$(Build.SourceVersion)--$(Build.BuildId)
nugetPath: $(Build.SourcesDirectory)\vowpalwabbit\.nuget\nuget.exe
failOnStderr: true
- task: PublishBuildArtifacts@1
Expand Down
11 changes: 8 additions & 3 deletions .scripts/package.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,14 @@ CALL %~dp0init.cmd

PUSHD %~dp0..

REM TODO: these should be read from the version props file, or similar
SET Version=8.6.1
SET Tag=-INTERNALONLY
REM TODO: these should be read from the version props file, or similar, with the ability to overload via env
lokitoth marked this conversation as resolved.
Show resolved Hide resolved
IF NOT DEFINED Version (
SET Version=8.6.1
)

IF NOT DEFINED Tag (
SET Tag=-INTERNALONLY
lokitoth marked this conversation as resolved.
Show resolved Hide resolved
)

SET RootRelativeOutputDirX64=%vwRoot%\vowpalwabbit\out\target\
SET RootRelativeOutputDirAnyCPU=%vwRoot%\vowpalwabbit\out\target\
Expand Down